Bug 57698 – Web Inspector: introduce support of 'optional' flag for command arguments

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Ilya Tikhonovsky]

%subj%

[Ilya Tikhonovsky]

Created attachment 87968 [details]
[patch] initial version

[Pavel Feldman]

Comment on attachment 87968 [details]
[patch] initial version

View in context: https://bugs.webkit.org/attachment.cgi?id=87968&action=review

> LayoutTests/ChangeLog:5
> +        Web Inspector: introduce support of 'optional' flag for command arguments.

It is not clear from the ChangeLog / perl script what the behavior would be, but here are the requirements as I see then:
1) it should be possible to make any number of parameters optional
2) optional parameters are the ones not transmitted as a part of the message
3) first parameter described could be made optional, not necessarily the last one
4) there should be a way to distinguish between "columnNumber = 0" and "not given optional columnNumber"

It sounds like (3) and (4) are not supported. Please explain what you intend to do in the bug like this prior to working on the change to aoid further confusion.

[Ilya Tikhonovsky]

Created attachment 87973 [details]
[patch] second version

test coverage was extended. See changes in report-API-errors.html, report-protocol-errors.html and runtime-agent.html

optional arguments are transferred by const pointers.

simplest implementation for optional arguments was added to the setBreackpoint* methods. I think we will fix that in another patch.

[Ilya Tikhonovsky]

Committed r82804: <http://trac.webkit.org/changeset/82804>

[WebKit Review Bot]

http://trac.webkit.org/changeset/82804 might have broken Windows XP Debug (Tests)
The following tests are not passing:
inspector/extensions/extensions-api.html
inspector/extensions/extensions.html