Bug 57683 - WK2 Icon Database API needs to be fleshed out
Summary: WK2 Icon Database API needs to be fleshed out
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit wx (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-01 16:50 PDT by Brady Eidson
Modified: 2011-04-04 09:03 PDT (History)
0 users

See Also:

Attachments
Patch v1 (20.91 KB, patch)
2011-04-01 17:01 PDT, Brady Eidson 		darin: review+
beidson: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2011-04-01 16:50:19 PDT 
WK2 Icon Database API needs to be fleshed out

At least by bringing it to parity with the WK1 API in terms of notifications, etc.
Comment 1 Brady Eidson 2011-04-01 17:01:57 PDT 
Created attachment 87945 [details]
Patch v1
Comment 2 Darin Adler 2011-04-01 17:35:32 PDT 
Comment on attachment 87945 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=87945&action=review

> Source/WebKit2/UIProcess/WebIconDatabase.cpp:208
> +{    

Stray whitespace crept in here.

> Source/WebKit2/UIProcess/WebIconDatabase.cpp:220
> +    RefPtr<WebURL> url = WebURL::create(pageURL);
> +    m_iconDatabaseClient.didChangeIconForPageURL(this, url.get());

I think this would read better without the local variable.
Comment 3 Brady Eidson 2011-04-04 09:03:04 PDT 
http://trac.webkit.org/changeset/82839