RESOLVED FIXED 57670
Add adoptWK to WKRetainPtr.h 
https://bugs.webkit.org/show_bug.cgi?id=57670
Summary Add adoptWK to WKRetainPtr.h
Sam Weinig
Reported 2011-04-01 15:28:09 PDT
Add adoptWK to WKRetainPtr.h
Attachments
Patch (11.64 KB, patch)
2011-04-01 15:31 PDT, Sam Weinig 		aroben: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2011-04-01 15:30:17 PDT
<rdar://problem/9224372>
Sam Weinig
Comment 2 2011-04-01 15:31:14 PDT
Created attachment 87929 [details] Patch
Adam Roben (:aroben)
Comment 3 2011-04-01 15:32:44 PDT
Comment on attachment 87929 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=87929&action=review > Source/WebKit2/UIProcess/API/cpp/WKRetainPtr.h:207 > +template<typename T> static inline WKRetainPtr<T> adoptWK(const T o) Is the const really helpful here? Won't all values of T be pointer types? > Tools/TestWebKitAPI/PlatformUtilities.h:1 > -/* > + /* Whoopsie!
Sam Weinig
Comment 4 2011-04-01 15:35:43 PDT
Committed r82730: <http://trac.webkit.org/changeset/82730>
WebKit Review Bot
Comment 5 2011-04-01 15:46:02 PDT
http://trac.webkit.org/changeset/82730 might have broken Windows Release (Build) and Windows Debug (Build)
Note You need to log in before you can comment on or make changes to this bug.