Bug 57670 - Add adoptWK to WKRetainPtr.h
Summary: Add adoptWK to WKRetainPtr.h
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Sam Weinig
Keywords: InRadar
Depends on:
Reported: 2011-04-01 15:28 PDT by Sam Weinig
Modified: 2011-04-01 15:46 PDT (History)
3 users (show)

See Also:

Patch (11.64 KB, patch)
2011-04-01 15:31 PDT, Sam Weinig
aroben: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2011-04-01 15:28:09 PDT
Add adoptWK to WKRetainPtr.h
Comment 1 Sam Weinig 2011-04-01 15:30:17 PDT
Comment 2 Sam Weinig 2011-04-01 15:31:14 PDT
Created attachment 87929 [details]
Comment 3 Adam Roben (:aroben) 2011-04-01 15:32:44 PDT
Comment on attachment 87929 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=87929&action=review

> Source/WebKit2/UIProcess/API/cpp/WKRetainPtr.h:207
> +template<typename T> static inline WKRetainPtr<T> adoptWK(const T o)

Is the const really helpful here? Won't all values of T be pointer types?

> Tools/TestWebKitAPI/PlatformUtilities.h:1
> -/*
> + /*

Comment 4 Sam Weinig 2011-04-01 15:35:43 PDT
Committed r82730: <http://trac.webkit.org/changeset/82730>
Comment 5 WebKit Review Bot 2011-04-01 15:46:02 PDT
http://trac.webkit.org/changeset/82730 might have broken Windows Release (Build) and Windows Debug (Build)