Bug 57664 – Stop preload scanning CSS when it's impossible to have another @import.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[James Simonsen]

Stop preload scanning CSS when it's impossible to have another @import.

[James Simonsen]

Created attachment 87920 [details]
Patch

[Adam Barth]

Comment on attachment 87920 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=87920&action=review

> Source/WebCore/html/parser/CSSPreloadScanner.cpp:68
> +        if (isHTMLSpace(c))
> +            { }

Woah.  That's how we usually do that.  I'd have a separate if clause that just has a break in it.

> Source/WebCore/html/parser/CSSPreloadScanner.cpp:90
>          else if (c == '*')
> -            ;
> +            { }

I'd also fix all of these.  :)

[James Simonsen]

webkit-patch upload complained. This is the way it told me to do it. I think it's referring to #4 under Braces in the style guide. I'll defer to your judgement though.

[Adam Barth]

{ } is preferred to ; but we should avoid both if we can.

[Adam Barth]

Comment on attachment 87920 [details]
Patch

As for the actual change, this looks great!

[James Simonsen]

Created attachment 88139 [details]
Patch for landing

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 88139 [details]:

fast/workers/storage/use-same-database-in-page-and-workers.html bug 50995 (author: [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 88139 [details]
Patch for landing

Clearing flags on attachment: 88139

Committed r82916: <http://trac.webkit.org/changeset/82916>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[WebKit Review Bot]

http://trac.webkit.org/changeset/82916 might have broken GTK Linux 32-bit Debug