WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
57632
Web Inspector: appropriateSelectorForNode() invokes the "localName" getter on DOMNode rather than function
https://bugs.webkit.org/show_bug.cgi?id=57632
Summary
Web Inspector: appropriateSelectorForNode() invokes the "localName" getter on...
Alexander Pavlov (apavlov)
Reported
2011-04-01 08:18:48 PDT
As advised by pfeldman, appropriateSelectorForNode() should become DOMNode.prototype.appropriateSelectorFor. This is the root cause of
http://code.google.com/p/chromium/issues/detail?id=77531
Attachments
[PATCH] Suggested fix
(4.75 KB, patch)
2011-04-01 09:30 PDT
,
Alexander Pavlov (apavlov)
pfeldman
: review-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Alexander Pavlov (apavlov)
Comment 1
2011-04-01 09:30:14 PDT
Created
attachment 87869
[details]
[PATCH] Suggested fix
Alexander Pavlov (apavlov)
Comment 2
2011-04-04 04:00:33 PDT
Committing to
http://svn.webkit.org/repository/webkit/trunk
... M Source/WebCore/ChangeLog M Source/WebCore/inspector/front-end/DOMAgent.js M Source/WebCore/inspector/front-end/EventListenersSidebarPane.js M Source/WebCore/inspector/front-end/StylesSidebarPane.js M Source/WebCore/inspector/front-end/utilities.js Committed
r82818
Pavel Feldman
Comment 3
2011-08-21 12:31:09 PDT
Comment on
attachment 87869
[details]
[PATCH] Suggested fix View in context:
https://bugs.webkit.org/attachment.cgi?id=87869&action=review
> Source/WebCore/inspector/front-end/DOMAgent.js:228 > + var lowerCaseName = this.localName() || node.nodeName().toLowerCase();
Alexander, Yury, this code is not right: "node" is not defined in this context. Could you please cover this with a test?
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug