Bug 57632 - Web Inspector: appropriateSelectorForNode() invokes the "localName" getter on DOMNode rather than function
Summary: Web Inspector: appropriateSelectorForNode() invokes the "localName" getter on...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P1 Normal
Assignee: Alexander Pavlov (apavlov)
URL:
Keywords: Regression
Depends on:
Blocks:
 
Reported: 2011-04-01 08:18 PDT by Alexander Pavlov (apavlov)
Modified: 2011-08-21 12:31 PDT (History)
10 users (show)

See Also:

Attachments
[PATCH] Suggested fix (4.75 KB, patch)
2011-04-01 09:30 PDT, Alexander Pavlov (apavlov) 		pfeldman: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Pavlov (apavlov) 2011-04-01 08:18:48 PDT 
As advised by pfeldman, appropriateSelectorForNode() should become DOMNode.prototype.appropriateSelectorFor.

This is the root cause of http://code.google.com/p/chromium/issues/detail?id=77531
Comment 1 Alexander Pavlov (apavlov) 2011-04-01 09:30:14 PDT 
Created attachment 87869 [details]
[PATCH] Suggested fix
Comment 2 Alexander Pavlov (apavlov) 2011-04-04 04:00:33 PDT 
Committing to http://svn.webkit.org/repository/webkit/trunk ...
        M       Source/WebCore/ChangeLog
        M       Source/WebCore/inspector/front-end/DOMAgent.js
        M       Source/WebCore/inspector/front-end/EventListenersSidebarPane.js
        M       Source/WebCore/inspector/front-end/StylesSidebarPane.js
        M       Source/WebCore/inspector/front-end/utilities.js
Committed r82818
Comment 3 Pavel Feldman 2011-08-21 12:31:09 PDT 
Comment on attachment 87869 [details]
[PATCH] Suggested fix

View in context: https://bugs.webkit.org/attachment.cgi?id=87869&action=review

> Source/WebCore/inspector/front-end/DOMAgent.js:228
> +        var lowerCaseName = this.localName() || node.nodeName().toLowerCase();

Alexander, Yury, this code is not right: "node" is not defined in this context. Could you please cover this with a test?