Bug 57630 - Leaks viewer gets some revision numbers wrong in the recent builds list
Summary: Leaks viewer gets some revision numbers wrong in the recent builds list
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-01 07:21 PDT by Adam Roben (:aroben)
Modified: 2011-04-01 08:19 PDT (History)
1 user (show)

See Also:

Attachments
Retrieve revision numbers from the build's got_revision property in Leaks Viewer (3.14 KB, patch)
2011-04-01 07:33 PDT, Adam Roben (:aroben) 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2011-04-01 07:21:10 PDT 
Leaks viewer gets some revision numbers wrong in the recent builds list. For instance, right now it has a link to <http://build.webkit.org/LeaksViewer/?url=http%3A%2F%2Fbuild.webkit.org%2F%2Fresults%2FSnowLeopard%20Intel%20Leaks%2Fr82671%20(15955)%2F>, but labels it as r82669, instead of r82671.
Comment 1 Adam Roben (:aroben) 2011-04-01 07:33:46 PDT 
Created attachment 87855 [details]
Retrieve revision numbers from the build's got_revision property in Leaks Viewer
Comment 2 WebKit Review Bot 2011-04-01 07:38:35 PDT 
Attachment 87855 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/BuildSlaveSupport/build.webkit.org-c..." exit_code: 1

Tools/ChangeLog:3:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Adam Roben (:aroben) 2011-04-01 08:19:27 PDT 
Committed r82682: <http://trac.webkit.org/changeset/82682>