WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
57628
Web Inspector: event should have "data" attribute, not "body"
https://bugs.webkit.org/show_bug.cgi?id=57628
Summary
Web Inspector: event should have "data" attribute, not "body"
Pavel Feldman
Reported
2011-04-01 06:43:37 PDT
Patch to follow.
Attachments
Patch
(4.90 KB, patch)
2011-04-01 06:49 PDT
,
Pavel Feldman
yurys
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Pavel Feldman
Comment 1
2011-04-01 06:49:39 PDT
Created
attachment 87852
[details]
Patch
Yury Semikhatsky
Comment 2
2011-04-01 06:54:04 PDT
Comment on
attachment 87852
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=87852&action=review
> Source/WebCore/inspector/CodeGeneratorInspector.pm:861 > + for (var key in messageObject.body)
This code is quite fragile since we rely on the keys order in the message but probably that's fine while the messages are formed also by our code.
Pavel Feldman
Comment 3
2011-04-01 07:11:08 PDT
M LayoutTests/ChangeLog M LayoutTests/inspector/protocol/console-agent-expected.txt M Source/WebCore/ChangeLog M Source/WebCore/inspector/CodeGeneratorInspector.pm Committed
r82680
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug