WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
57622
Web Inspector: [Extensions API] Merge WatchExpressionSidebarPane into ExtensionSidebarPane
https://bugs.webkit.org/show_bug.cgi?id=57622
Summary
Web Inspector: [Extensions API] Merge WatchExpressionSidebarPane into Extensi...
Andrey Kosyakov
Reported
2011-04-01 06:06:07 PDT
ExtensionSidebarPane.setPage() will set content of the sidebar to page specified.
Attachments
patch
(7.35 KB, patch)
2011-04-01 06:06 PDT
,
Andrey Kosyakov
yurys
: review-
Details
Formatted Diff
Diff
patch
(9.62 KB, patch)
2011-04-04 01:10 PDT
,
Andrey Kosyakov
yurys
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Andrey Kosyakov
Comment 1
2011-04-01 06:06:47 PDT
Created
attachment 87851
[details]
patch
Yury Semikhatsky
Comment 2
2011-04-04 00:54:24 PDT
Comment on
attachment 87851
[details]
patch ChangeLog entry is missing, otherwise looks good.
Andrey Kosyakov
Comment 3
2011-04-04 01:10:09 PDT
Created
attachment 88041
[details]
patch Oops. Added ChangeLog entries.
WebKit Review Bot
Comment 4
2011-04-04 02:31:31 PDT
http://trac.webkit.org/changeset/82806
might have broken SnowLeopard Intel Release (Tests) The following tests are not passing: inspector/extensions/extensions-api.html inspector/extensions/extensions.html
Andrey Kosyakov
Comment 5
2011-04-04 07:28:43 PDT
Manually committed as
r82206
:
http://trac.webkit.org/changeset/82806
Follow-up fix in
r82814
:
http://trac.webkit.org/changeset/82814
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug