Bug 57622 - Web Inspector: [Extensions API] Merge WatchExpressionSidebarPane into ExtensionSidebarPane
Summary: Web Inspector: [Extensions API] Merge WatchExpressionSidebarPane into Extensi...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andrey Kosyakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-01 06:06 PDT by Andrey Kosyakov
Modified: 2011-04-04 07:28 PDT (History)
12 users (show)

See Also:

Attachments
patch (7.35 KB, patch)
2011-04-01 06:06 PDT, Andrey Kosyakov 		yurys: review-
Details | Formatted Diff | Diff
patch (9.62 KB, patch)
2011-04-04 01:10 PDT, Andrey Kosyakov 		yurys: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Kosyakov 2011-04-01 06:06:07 PDT 
ExtensionSidebarPane.setPage() will set content of the sidebar to page specified.
Comment 1 Andrey Kosyakov 2011-04-01 06:06:47 PDT 
Created attachment 87851 [details]
patch
Comment 2 Yury Semikhatsky 2011-04-04 00:54:24 PDT 
Comment on attachment 87851 [details]
patch

ChangeLog entry is missing, otherwise looks good.
Comment 3 Andrey Kosyakov 2011-04-04 01:10:09 PDT 
Created attachment 88041 [details]
patch

Oops. Added ChangeLog entries.
Comment 4 WebKit Review Bot 2011-04-04 02:31:31 PDT 
http://trac.webkit.org/changeset/82806 might have broken SnowLeopard Intel Release (Tests)
The following tests are not passing:
inspector/extensions/extensions-api.html
inspector/extensions/extensions.html
Comment 5 Andrey Kosyakov 2011-04-04 07:28:43 PDT 
Manually committed as r82206: http://trac.webkit.org/changeset/82806
Follow-up fix in r82814: http://trac.webkit.org/changeset/82814