Bug 57594 - fast/preloader/scan-body-from-head.html is flaky
Summary: fast/preloader/scan-body-from-head.html is flaky
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-31 16:45 PDT by Adam Barth
Modified: 2011-03-31 23:07 PDT (History)
5 users (show)

See Also:

Attachments
Patch (5.95 KB, patch)
2011-03-31 17:59 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2011-03-31 16:45:56 PDT 
The loads in scan-body-from-head.html can load in any order.  We can either use setSerializeHTTPLoads to serialize the loads or split the test into three pieces, each with one load.  The former reduces coverage because setSerializeHTTPLoads isn't implemented everywhere (which could be fixed), so I favor the latter.
Comment 1 Adam Barth 2011-03-31 17:59:50 PDT 
Created attachment 87812 [details]
Patch
Comment 2 Tony Gentilcore 2011-03-31 18:07:43 PDT 
Comment on attachment 87812 [details]
Patch

Thanks for the fix!
Comment 3 WebKit Commit Bot 2011-03-31 20:44:07 PDT 
The commit-queue encountered the following flaky tests while processing attachment 87812 [details]:

http/tests/media/video-play-progress.html bug 57607
The commit-queue is continuing to process your patch.
Comment 4 WebKit Commit Bot 2011-03-31 20:46:07 PDT 
Comment on attachment 87812 [details]
Patch

Clearing flags on attachment: 87812

Committed r82658: <http://trac.webkit.org/changeset/82658>
Comment 5 WebKit Commit Bot 2011-03-31 20:46:12 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 WebKit Review Bot 2011-03-31 22:42:05 PDT 
http://trac.webkit.org/changeset/82658 might have broken SnowLeopard Intel Release (WebKit2 Tests)
The following tests are not passing:
fast/preloader/scan-body-from-head-import.html
fast/preloader/scan-body-from-head-script.html
Comment 7 Adam Barth 2011-03-31 23:07:59 PDT 
I added these to the WebKit2 Skipped list b/c it already contains all the other preload scanner tests.  WebKit2 is missing the necessary DRT API.