Bug 57577 - [chromium] Fix ownership semantics for LayerChromium/CCLayerImpl
Summary: [chromium] Fix ownership semantics for LayerChromium/CCLayerImpl
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adrienne Walker
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-31 14:15 PDT by Adrienne Walker
Modified: 2011-03-31 15:07 PDT (History)
4 users (show)

See Also:


Attachments
Patch (10.74 KB, patch)
2011-03-31 14:32 PDT, Adrienne Walker
jamesr: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adrienne Walker 2011-03-31 14:15:36 PDT
[chromium] Fix ownership semantics for LayerChromium/CCLayerImpl
Comment 1 Adrienne Walker 2011-03-31 14:32:50 PDT
Created attachment 87787 [details]
Patch
Comment 2 James Robinson 2011-03-31 14:38:27 PDT
Comment on attachment 87787 [details]
Patch

You knew I was gonna ask - test?
Comment 3 Adrienne Walker 2011-03-31 14:42:52 PDT
If I knew how to reproduce this bug reliably, I would happily check in a test.  I just don't want to check in a test with setTimeout('window.location.reload()', 100) in it.  That would go directly into the FLAKY bin.  Do you have any suggestions on how to test this better?

However, I did run it through the LayoutTests/compositing suite (which caught a correctness issue that I fixed).
Comment 4 Adrienne Walker 2011-03-31 15:07:19 PDT
Committed r82624: <http://trac.webkit.org/changeset/82624>