Bug 57574 – Preload scanner fails to pick up resources from document.write() output

• Status: RESOLVED
• Resolution: FIXED
• Component: Page Loading

[Antti Koivisto]

With this

<script>
    document.write('<script src="resources/document-write-plaintext.js"></sc'+'ript>');
    document.write('<script src="resources/script1.js"></sc'+'ript>');
</script>

preload scanner does fails to pick up the script1.js. This used to work and was lost with the HTML5 parser.

[Antti Koivisto]

Created attachment 87785 [details]
patch

- Scan script inserted source using a separate preload scanner.
- Make the main preload scanner correctly process the remaining source if script execution blocked the parser.

[Oliver Hunt]

Comment on attachment 87785 [details]
patch

r=me, but it would be good to have a test for nested document.write()

[Antti Koivisto]

http://trac.webkit.org/changeset/82631

[Adam Barth]

Comment on attachment 87785 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=87785&action=review

> LayoutTests/fast/preloader/document-write.html:13
> +    if (window.layoutTestController)
> +        setTimeout(function(){ layoutTestController.notifyDone() }, 1000);

This seems like it will make the test slow and flaky.  :(

[WebKit Review Bot]

http://trac.webkit.org/changeset/82631 might have broken Leopard Intel Release (Tests)
The following tests are not passing:
fast/preloader/document-write-2.html
fast/preloader/document-write.html
fast/preloader/scan-body-from-head.html

[Antti Koivisto]

<rdar://problem/9219111>