Bug 57572 - WebKitTestRunner needs layoutTestController.setAllowFileAccessFromFileURLs
Summary: WebKitTestRunner needs layoutTestController.setAllowFileAccessFromFileURLs
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Chang Shu
URL:
Keywords:
Depends on: 59638
Blocks:
  Show dependency tree / graph
 
Reported: 2011-03-31 13:40 PDT by Chang Shu
Modified: 2011-04-27 14:54 PDT (History)
3 users (show)

See Also:

Attachments
fix patch (11.15 KB, patch)
2011-04-04 08:00 PDT, Chang Shu 		darin: review+
cshu: commit-queue-
Details | Formatted Diff | Diff
fix patch 2: follow review (11.71 KB, patch)
2011-04-04 08:43 PDT, Chang Shu 		no flags Details | Formatted Diff | Diff
fix patch: code refactory (10.66 KB, patch)
2011-04-20 10:49 PDT, Chang Shu 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chang Shu 2011-03-31 13:40:10 PDT 
Fails at least:
fast/frames/location-change-no-file-access.html
fast/xmlhttprequest/xmlhttprequest-no-file-access.html
Comment 1 Chang Shu 2011-04-04 08:00:03 PDT 
Created attachment 88059 [details]
fix patch
Comment 2 Darin Adler 2011-04-04 08:34:13 PDT 
Comment on attachment 88059 [details]
fix patch

View in context: https://bugs.webkit.org/attachment.cgi?id=88059&action=review

> LayoutTests/platform/mac-wk2/Skipped:1443
> -# WebKitTestRunner needs layoutTestController.setAllowFileAccessFromFileURLs
> -# <https://bugs.webkit.org/show_bug.cgi?id=57572>
> -fast/frames/location-change-no-file-access.html
>  fast/xmlhttprequest/xmlhttprequest-no-file-access.html
> -
>  fast/xmlhttprequest/xmlhttprequest-nonexistent-file.html

This orphans these still-skipped tests in a section with no label. It’s better to move them to an appropriately-labeled section.
Comment 3 Chang Shu 2011-04-04 08:43:20 PDT 
Created attachment 88064 [details]
fix patch 2: follow review
Comment 4 Chang Shu 2011-04-04 09:06:03 PDT 
Darin, can you r+ again? thx
Comment 5 WebKit Commit Bot 2011-04-04 10:18:40 PDT 
The commit-queue encountered the following flaky tests while processing attachment 88059 [details]:

http/tests/websocket/tests/multiple-connections.html bug 53825 (author: abarth@webkit.org)
The commit-queue is continuing to process your patch.
Comment 6 WebKit Commit Bot 2011-04-04 11:27:24 PDT 
The commit-queue encountered the following flaky tests while processing attachment 88064 [details]:

java/lc3/JSBoolean/boolean-002-n.html bug 57769 (author: ap@webkit.org)
The commit-queue is continuing to process your patch.
Comment 7 WebKit Commit Bot 2011-04-04 11:29:38 PDT 
Comment on attachment 88064 [details]
fix patch 2: follow review

Clearing flags on attachment: 88064

Committed r82848: <http://trac.webkit.org/changeset/82848>
Comment 8 WebKit Commit Bot 2011-04-04 11:29:44 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 9 Chang Shu 2011-04-20 10:44:14 PDT 
It is not necessary to update Webkit2 preference while calling LayoutTestController.setAllowFileAccessFromFileURLs and LayoutTestController.setAllowUniveralAccessFromFileURLs. I am going to upload a patch for code refactory.
Comment 10 Chang Shu 2011-04-20 10:49:26 PDT 
Created attachment 90360 [details]
fix patch: code refactory
Comment 11 Laszlo Gombos 2011-04-26 16:04:35 PDT 
Comment on attachment 90360 [details]
fix patch: code refactory

lgtm, r+.
Comment 12 WebKit Commit Bot 2011-04-26 16:43:14 PDT 
Comment on attachment 90360 [details]
fix patch: code refactory

Clearing flags on attachment: 90360

Committed r84980: <http://trac.webkit.org/changeset/84980>
Comment 13 WebKit Commit Bot 2011-04-26 16:43:20 PDT 
All reviewed patches have been landed.  Closing bug.