Failed tests include at least: storage/quota-tracking.html
Created attachment 164123 [details] Patch
Comment on attachment 164123 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=164123&action=review > Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp:546 > + if (!newQuota) { > + WebProcess::shared().connection()->sendSync( > + Messages::WebPageProxy::ExceededDatabaseQuota(webFrame->frameID(), origin->databaseIdentifier(), databaseName, details.displayName(), currentQuota, currentOriginUsage, details.currentUsage(), details.expectedUsage()), > + Messages::WebPageProxy::ExceededDatabaseQuota::Reply(newQuota), m_page->pageID()); > + } So zero can not exceed, makes sense
Created attachment 164171 [details] Python script If anyone knows python better than me, this script can probably be fixed up and included in Tools/Scripts
Comment on attachment 164171 [details] Python script Wrong bug!
Comment on attachment 164123 [details] Patch Clearing flags on attachment: 164123 Committed r128623: <http://trac.webkit.org/changeset/128623>
All reviewed patches have been landed. Closing bug.
Why did you change kWKBundlePageUIClientCurrentVersion? The previous version change was just two days ago, I'm pretty sure that's not how it is supposed to work.
Chris told me that Anders told him to bump the version every time he added a new method. I personally think that we can do better.
(In reply to comment #7) > Why did you change kWKBundlePageUIClientCurrentVersion? The previous version change was just two days ago, I'm pretty sure that's not how it is supposed to work. Is there a rule regarding when we are supposed to bump the version? So far my understanding was that I should bump the version every time I add a callback.