WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
57570
WebKitTestRunner needs layoutTestController.dumpDatabaseCallbacks
https://bugs.webkit.org/show_bug.cgi?id=57570
Summary
WebKitTestRunner needs layoutTestController.dumpDatabaseCallbacks
Chang Shu
Reported
2011-03-31 13:18:08 PDT
Failed tests include at least: storage/quota-tracking.html
Attachments
Patch
(23.10 KB, patch)
2012-09-14 06:04 PDT
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Python script
(3.51 KB, text/x-python)
2012-09-14 09:36 PDT
,
Kenneth Rohde Christiansen
no flags
Details
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Chris Dumez
Comment 1
2012-09-14 06:04:41 PDT
Created
attachment 164123
[details]
Patch
Kenneth Rohde Christiansen
Comment 2
2012-09-14 09:32:55 PDT
Comment on
attachment 164123
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=164123&action=review
> Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp:546 > + if (!newQuota) { > + WebProcess::shared().connection()->sendSync( > + Messages::WebPageProxy::ExceededDatabaseQuota(webFrame->frameID(), origin->databaseIdentifier(), databaseName, details.displayName(), currentQuota, currentOriginUsage, details.currentUsage(), details.expectedUsage()), > + Messages::WebPageProxy::ExceededDatabaseQuota::Reply(newQuota), m_page->pageID()); > + }
So zero can not exceed, makes sense
Kenneth Rohde Christiansen
Comment 3
2012-09-14 09:36:25 PDT
Created
attachment 164171
[details]
Python script If anyone knows python better than me, this script can probably be fixed up and included in Tools/Scripts
Kenneth Rohde Christiansen
Comment 4
2012-09-14 09:36:51 PDT
Comment on
attachment 164171
[details]
Python script Wrong bug!
WebKit Review Bot
Comment 5
2012-09-14 09:59:14 PDT
Comment on
attachment 164123
[details]
Patch Clearing flags on attachment: 164123 Committed
r128623
: <
http://trac.webkit.org/changeset/128623
>
WebKit Review Bot
Comment 6
2012-09-14 09:59:19 PDT
All reviewed patches have been landed. Closing bug.
Alexey Proskuryakov
Comment 7
2012-09-14 10:11:48 PDT
Why did you change kWKBundlePageUIClientCurrentVersion? The previous version change was just two days ago, I'm pretty sure that's not how it is supposed to work.
Kenneth Rohde Christiansen
Comment 8
2012-09-14 10:14:00 PDT
Chris told me that Anders told him to bump the version every time he added a new method. I personally think that we can do better.
Chris Dumez
Comment 9
2012-09-14 10:17:06 PDT
(In reply to
comment #7
)
> Why did you change kWKBundlePageUIClientCurrentVersion? The previous version change was just two days ago, I'm pretty sure that's not how it is supposed to work.
Is there a rule regarding when we are supposed to bump the version? So far my understanding was that I should bump the version every time I add a callback.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug