We need to be able to use ContextMenuParams for file entity identification for ChromeOS file browser. The only change needed on WK side is to add a new enum WebKit::WebContextMenuData value to WebContextMenuData::MediaType - MediaTypeFile.
Created attachment 87774 [details] Added MediaTypeFile enum value to WebContextMenuData::MediaType
This is a trivial change and by itself it seems fine, but I find it hard to understand how this enum change does anything and why it is beneficial and if it useful (w/o doing any other changes in WebKit), why this enum is upstream at all. Thus my reluctance to r+.
Summary: There is a function/strucutre in WebKit that stores these enum values without caring what they are and a new one is needed for purposes on the Chromium side.
Comment on attachment 87774 [details] Added MediaTypeFile enum value to WebContextMenuData::MediaType Clearing flags on attachment: 87774 Committed r82976: <http://trac.webkit.org/changeset/82976>
All reviewed patches have been landed. Closing bug.
Reopening this bug as we need to roll out the patch - it breaks chromium build
Here's how to do this patch in a way that won't break any builds. 1. Submit a patch on the chromium side which fixes the build for when this enum is added but ifdef all the places. Something like #ifdef WebContextMenuDataFileTypeDefined but with proper casing. 2. Put up with patch and add a #define WebContextMenuDataFileTypeDefined in the header file file. 3. Once it gets into chromium, you remove all the ifdef's and submit that patch. 4. Then one final patch in WebKit which removes #define WebContextMenuDataFileTypeDefined from this header.
Created attachment 88356 [details] Added MediaTypeFile enum value to WebContextMenuData::MediaType... with fix for Chromium side added new define WEBCONTEXT_MEDIATYPEFILE_DEFINED that should prevent Chromium build from breaking this needs to land after http://codereview.chromium.org/6799005/
Comment on attachment 88356 [details] Added MediaTypeFile enum value to WebContextMenuData::MediaType... with fix for Chromium side Clearing flags on attachment: 88356 Committed r83023: <http://trac.webkit.org/changeset/83023>
http://trac.webkit.org/changeset/83023 might have broken GTK Linux 32-bit Debug