Bug 57548 – Web Inspector: Separate sendMessageToFrontend function from InspectorClient to individual interface

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Sergey Vorobyev]

For improve inspector architecture and implement background network events collection,
we need split InspectorClient, and separate sendMessageToFrontend to another class.

[Sergey Vorobyev]

Created attachment 87846 [details]
Patch, separated sendMessageToFrontend from InspectorClient

[Yury Semikhatsky]

Comment on attachment 87846 [details]
Patch, separated sendMessageToFrontend from InspectorClient

View in context: https://bugs.webkit.org/attachment.cgi?id=87846&action=review

> Source/WebCore/WebCore.gypi:3224
> +            'inspector/InspectorFrontendChannel.h',

Mind alphabetic order.

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:22772
> +				227777601345DEA9008EA455 /* InspectorFrontendChannel.h in Headers */,

Other headers in this section seem to be sorted, please keep the order.

> Source/WebCore/inspector/CodeGeneratorInspector.pm:100
> +$typeTransform{"InspectorFrontendChannel"} = {

I think may not need "InspectorClient" forward declaration and header import anymore, please check and remove corresponding code from the generator if it is so.

> Source/WebCore/inspector/InspectorClient.h:29
> +#include "InspectorFrontendChannel.h"

Please add  Copyright (C) 2011 Google Inc.... header to the license above since you're modifying this file.

[Sergey Vorobyev]

Created attachment 87856 [details]
Remove InspectorClient from CodeGeneratorInspector

[Sergey Vorobyev]

Comment on attachment 87846 [details]
Patch, separated sendMessageToFrontend from InspectorClient

View in context: https://bugs.webkit.org/attachment.cgi?id=87846&action=review

>> Source/WebCore/WebCore.gypi:3224
>> +            'inspector/InspectorFrontendChannel.h',
> 
> Mind alphabetic order.

Done.

>> Source/WebCore/WebCore.xcodeproj/project.pbxproj:22772
>> +				227777601345DEA9008EA455 /* InspectorFrontendChannel.h in Headers */,
> 
> Other headers in this section seem to be sorted, please keep the order.

This is auto-generated change, I just added file to the project in xcode

>> Source/WebCore/inspector/CodeGeneratorInspector.pm:100
>> +$typeTransform{"InspectorFrontendChannel"} = {
> 
> I think may not need "InspectorClient" forward declaration and header import anymore, please check and remove corresponding code from the generator if it is so.

Done.

>> Source/WebCore/inspector/InspectorClient.h:29
>> +#include "InspectorFrontendChannel.h"
> 
> Please add  Copyright (C) 2011 Google Inc.... header to the license above since you're modifying this file.

Done.

[Yury Semikhatsky]

(In reply to comment #4)
> (From update of attachment 87846 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=87846&action=review
> >> Source/WebCore/WebCore.xcodeproj/project.pbxproj:22772
> >> +				227777601345DEA9008EA455 /* InspectorFrontendChannel.h in Headers */,
> > 
> > Other headers in this section seem to be sorted, please keep the order.
> 
I know, but sometimes they need manual intervention and that is why other headers in the same section are sorted.

[Sergey Vorobyev]

Created attachment 88046 [details]
Fixed order of files in project.xcode

[Yury Semikhatsky]

Committed r82810: <http://trac.webkit.org/changeset/82810>