WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
57542
[Qt] Make WebKitLibraries optional for building QtWebKit
https://bugs.webkit.org/show_bug.cgi?id=57542
Summary
[Qt] Make WebKitLibraries optional for building QtWebKit
Laszlo Gombos
Reported
2011-03-31 06:33:25 PDT
build-webkit scripts fails if WebKitLibraries directory is not available even though it is not required to build QtWebKit. Perhaps we should guard with WebKitLibraries test with isQt(). This could be useful if one would only want to check out Tools and Source directory or for releasing QtWebKit into various platforms.
Attachments
Patch
(1.47 KB, patch)
2011-03-31 07:53 PDT
,
Csaba Osztrogonác
no flags
Details
Formatted Diff
Diff
Patch
(1.47 KB, patch)
2011-03-31 07:55 PDT
,
Csaba Osztrogonác
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1
2011-03-31 07:53:01 PDT
Created
attachment 87727
[details]
Patch
Csaba Osztrogonác
Comment 2
2011-03-31 07:55:44 PDT
Created
attachment 87729
[details]
Patch
Andras Becsi
Comment 3
2011-03-31 07:59:03 PDT
Comment on
attachment 87729
[details]
Patch LGTM.
Build Bot
Comment 4
2011-03-31 08:10:19 PDT
Attachment 87727
[details]
did not build on win: Build output:
http://queues.webkit.org/results/8313353
Csaba Osztrogonác
Comment 5
2011-04-04 09:03:53 PDT
Laszlo: review ping?
Laszlo Gombos
Comment 6
2011-04-05 07:54:46 PDT
Comment on
attachment 87729
[details]
Patch r=me. Thanks.
Csaba Osztrogonác
Comment 7
2011-04-05 08:07:57 PDT
Comment on
attachment 87729
[details]
Patch Landed in
http://trac.webkit.org/changeset/82939
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug