Bug 57542 - [Qt] Make WebKitLibraries optional for building QtWebKit
Summary: [Qt] Make WebKitLibraries optional for building QtWebKit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P4 Normal
Assignee: Nobody
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2011-03-31 06:33 PDT by Laszlo Gombos
Modified: 2011-04-05 08:08 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.47 KB, patch)
2011-03-31 07:53 PDT, Csaba Osztrogonác 		no flags Details | Formatted Diff | Diff
Patch (1.47 KB, patch)
2011-03-31 07:55 PDT, Csaba Osztrogonác 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Laszlo Gombos 2011-03-31 06:33:25 PDT 
build-webkit scripts fails if WebKitLibraries directory is not available even though it is not required to build QtWebKit. Perhaps we should guard with WebKitLibraries test with isQt().
This could be useful if one would only want to check out Tools and Source directory or for releasing QtWebKit into various platforms.
Comment 1 Csaba Osztrogonác 2011-03-31 07:53:01 PDT 
Created attachment 87727 [details]
Patch
Comment 2 Csaba Osztrogonác 2011-03-31 07:55:44 PDT 
Created attachment 87729 [details]
Patch
Comment 3 Andras Becsi 2011-03-31 07:59:03 PDT 
Comment on attachment 87729 [details]
Patch

LGTM.
Comment 4 Build Bot 2011-03-31 08:10:19 PDT 
Attachment 87727 [details] did not build on win:
Build output: http://queues.webkit.org/results/8313353
Comment 5 Csaba Osztrogonác 2011-04-04 09:03:53 PDT 
Laszlo: review ping?
Comment 6 Laszlo Gombos 2011-04-05 07:54:46 PDT 
Comment on attachment 87729 [details]
Patch

r=me. Thanks.
Comment 7 Csaba Osztrogonác 2011-04-05 08:07:57 PDT 
Comment on attachment 87729 [details]
Patch

Landed in http://trac.webkit.org/changeset/82939