Bug 57538 - Web Inspector: CSS domain - make a "range" object, get rid of "properties" object for Style objects
: Web Inspector: CSS domain - make a "range" object, get rid of "properties" ob...
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated)
: 528+ (Nightly build)
: All All
: P2 Normal
Assigned To: Alexander Pavlov (apavlov)
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-03-31 04:49 PDT by Alexander Pavlov (apavlov)
Modified: 2011-03-31 09:00 PDT (History)
13 users (show)

See Also:


Attachments
[PATCH] Suggested solution (10.86 KB, patch)
2011-03-31 05:44 PDT, Alexander Pavlov (apavlov)
no flags Details | Formatted Diff | Diff
[ (10.81 KB, patch)
2011-03-31 05:46 PDT, Alexander Pavlov (apavlov)
no flags Details | Formatted Diff | Diff
[PATCH] Remove inadvertently added blank line (10.81 KB, patch)
2011-03-31 05:47 PDT, Alexander Pavlov (apavlov)
yurys: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Pavlov (apavlov) 2011-03-31 04:49:30 PDT
"startOffset"/"endOffset" should reside in a separate "range" object, and the "properties" object (for the CSS style) should go away (width/height get inlined into the CSS style object).
Comment 1 Alexander Pavlov (apavlov) 2011-03-31 05:44:14 PDT
Created attachment 87706 [details]
[PATCH] Suggested solution
Comment 2 Alexander Pavlov (apavlov) 2011-03-31 05:46:20 PDT
Created attachment 87707 [details]
[
Comment 3 Alexander Pavlov (apavlov) 2011-03-31 05:47:11 PDT
Created attachment 87708 [details]
[PATCH] Remove inadvertently added blank line
Comment 4 Yury Semikhatsky 2011-03-31 06:57:51 PDT
Comment on attachment 87708 [details]
[PATCH] Remove inadvertently added blank line

View in context: https://bugs.webkit.org/attachment.cgi?id=87708&action=review

> LayoutTests/inspector/styles/styles-source-offsets.html:12
> +    function rangeText(range)

Can you move this method into a common file for inspector CSS tests?

> LayoutTests/inspector/styles/styles-source-offsets.html:33
> +        InspectorTest.addResult(header + " [" + style.range.start  + "-" + style.range.end + "]");

Please use rangeText instead.
Comment 5 WebKit Review Bot 2011-03-31 08:28:03 PDT
http://trac.webkit.org/changeset/82578 might have broken GTK Linux 32-bit Release
Comment 6 Alexander Pavlov (apavlov) 2011-03-31 09:00:08 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	LayoutTests/ChangeLog
	M	LayoutTests/http/tests/inspector/elements-test.js
	M	LayoutTests/inspector/styles/get-set-stylesheet-text.html
	M	LayoutTests/inspector/styles/styles-new-API.html
	M	LayoutTests/inspector/styles/styles-source-offsets.html
	M	Source/WebCore/ChangeLog
	M	Source/WebCore/inspector/InspectorStyleSheet.cpp
	M	Source/WebCore/inspector/front-end/AuditRules.js
	M	Source/WebCore/inspector/front-end/CSSStyleModel.js
Committed r82578