Bug 57538 - Web Inspector: CSS domain - make a "range" object, get rid of "properties" object for Style objects
: Web Inspector: CSS domain - make a "range" object, get rid of "properties" ob...
Status: RESOLVED FIXED
: WebKit
Web Inspector (Deprecated)
: 528+ (Nightly build)
: All All
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2011-03-31 04:49 PST by
Modified: 2011-03-31 09:00 PST (History)


Attachments
[PATCH] Suggested solution (10.86 KB, patch)
2011-03-31 05:44 PST, Alexander Pavlov (apavlov)
no flags Review Patch | Details | Formatted Diff | Diff
[ (10.81 KB, patch)
2011-03-31 05:46 PST, Alexander Pavlov (apavlov)
no flags Review Patch | Details | Formatted Diff | Diff
[PATCH] Remove inadvertently added blank line (10.81 KB, patch)
2011-03-31 05:47 PST, Alexander Pavlov (apavlov)
yurys: review+
Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2011-03-31 04:49:30 PST
"startOffset"/"endOffset" should reside in a separate "range" object, and the "properties" object (for the CSS style) should go away (width/height get inlined into the CSS style object).
------- Comment #1 From 2011-03-31 05:44:14 PST -------
Created an attachment (id=87706) [details]
[PATCH] Suggested solution
------- Comment #2 From 2011-03-31 05:46:20 PST -------
Created an attachment (id=87707) [details]
[
------- Comment #3 From 2011-03-31 05:47:11 PST -------
Created an attachment (id=87708) [details]
[PATCH] Remove inadvertently added blank line
------- Comment #4 From 2011-03-31 06:57:51 PST -------
(From update of attachment 87708 [details])
View in context: https://bugs.webkit.org/attachment.cgi?id=87708&action=review

> LayoutTests/inspector/styles/styles-source-offsets.html:12
> +    function rangeText(range)

Can you move this method into a common file for inspector CSS tests?

> LayoutTests/inspector/styles/styles-source-offsets.html:33
> +        InspectorTest.addResult(header + " [" + style.range.start  + "-" + style.range.end + "]");

Please use rangeText instead.
------- Comment #5 From 2011-03-31 08:28:03 PST -------
http://trac.webkit.org/changeset/82578 might have broken GTK Linux 32-bit Release
------- Comment #6 From 2011-03-31 09:00:08 PST -------
Committing to http://svn.webkit.org/repository/webkit/trunk ...
    M    LayoutTests/ChangeLog
    M    LayoutTests/http/tests/inspector/elements-test.js
    M    LayoutTests/inspector/styles/get-set-stylesheet-text.html
    M    LayoutTests/inspector/styles/styles-new-API.html
    M    LayoutTests/inspector/styles/styles-source-offsets.html
    M    Source/WebCore/ChangeLog
    M    Source/WebCore/inspector/InspectorStyleSheet.cpp
    M    Source/WebCore/inspector/front-end/AuditRules.js
    M    Source/WebCore/inspector/front-end/CSSStyleModel.js
Committed r82578