Bug 57529 - WebKit2: Save as PDF in Safari provides Untitled as default file name
Summary: WebKit2: Save as PDF in Safari provides Untitled as default file name
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: PDF (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.6
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar, PlatformOnly
Depends on:
Blocks:
 
Reported: 2011-03-31 00:51 PDT by Jer Noble
Modified: 2011-04-01 16:08 PDT (History)
0 users

See Also:

Attachments
Patch (1.59 KB, patch)
2011-03-31 01:26 PDT, Jer Noble 		mitz: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2011-03-31 00:51:19 PDT 
When saving as PDF from Safari, the default file name provided is Untitled.
Comment 1 Jer Noble 2011-03-31 00:51:36 PDT 
<rdar://problem/8998510>
Comment 2 Jer Noble 2011-03-31 01:26:00 PDT 
Created attachment 87679 [details]
Patch
Comment 3 Alexey Proskuryakov 2011-04-01 09:15:18 PDT 
Comment on attachment 87679 [details]
Patch

Interestingly, this is not how it works in WebKit1 - my theory is that NSPrintOperation gets job title from window title by default, but WKPrintingView doesn't have a window.
Comment 4 Jer Noble 2011-04-01 10:10:04 PDT 
That's exactly right.  [NSPrintOperation setJobTitle:] overrides the default behavior, which is to call [NSView printJobTitle], which returns the document's displayName.
Comment 5 Jer Noble 2011-04-01 16:08:40 PDT 
Committed r82737: <http://trac.webkit.org/changeset/82737>