WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
57518
Clean up the sandbox parameter code
https://bugs.webkit.org/show_bug.cgi?id=57518
Summary
Clean up the sandbox parameter code
Anders Carlsson
Reported
2011-03-30 18:38:43 PDT
Clean up the sandbox parameter code
Attachments
Patch
(8.89 KB, patch)
2011-03-30 18:41 PDT
,
Anders Carlsson
sam
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Anders Carlsson
Comment 1
2011-03-30 18:41:11 PDT
Created
attachment 87653
[details]
Patch
Sam Weinig
Comment 2
2011-03-30 18:43:06 PDT
Comment on
attachment 87653
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=87653&action=review
> Source/WebKit2/WebProcess/mac/WebProcessMac.mm:153 > +static void appendReadonlySandboxDirectory(Vector<const char*>& vector, const char* name, const String& path) > +{ > + appendSandboxParameterPathInternal(vector, name, [(NSString *)path fileSystemRepresentation]); > +} > + > +static void appendReadwriteSandboxDirectory(Vector<const char*>& vector, const char* name, const String& path) > +{ > + appendSandboxParameterPathInternal(vector, name, [(NSString *)path fileSystemRepresentation]); > +}
These should take NSStrings.
Anders Carlsson
Comment 3
2011-03-30 18:45:28 PDT
Committed
r82530
: <
http://trac.webkit.org/changeset/82530
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug