Bug 57518 - Clean up the sandbox parameter code
Summary: Clean up the sandbox parameter code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-30 18:38 PDT by Anders Carlsson
Modified: 2011-03-30 18:45 PDT (History)
0 users

See Also:

Attachments
Patch (8.89 KB, patch)
2011-03-30 18:41 PDT, Anders Carlsson 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2011-03-30 18:38:43 PDT 
Clean up the sandbox parameter code
Comment 1 Anders Carlsson 2011-03-30 18:41:11 PDT 
Created attachment 87653 [details]
Patch
Comment 2 Sam Weinig 2011-03-30 18:43:06 PDT 
Comment on attachment 87653 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=87653&action=review

> Source/WebKit2/WebProcess/mac/WebProcessMac.mm:153
> +static void appendReadonlySandboxDirectory(Vector<const char*>& vector, const char* name, const String& path)
> +{
> +    appendSandboxParameterPathInternal(vector, name, [(NSString *)path fileSystemRepresentation]);
> +}
> +
> +static void appendReadwriteSandboxDirectory(Vector<const char*>& vector, const char* name, const String& path)
> +{
> +    appendSandboxParameterPathInternal(vector, name, [(NSString *)path fileSystemRepresentation]);
> +}

These should take NSStrings.
Comment 3 Anders Carlsson 2011-03-30 18:45:28 PDT 
Committed r82530: <http://trac.webkit.org/changeset/82530>