Bug 57509 – Regression: VO cursor doesn't follow KB focus back into HTML view

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[chris fleizach]

1. Load attached test case with VO with WK2.
2. Tab into the text field. VO cursor follows.
3. Shift+Tab back to the "new tab" button. VO cursor follows.
4. Tab into the text field. 

* RESULTS
VO cursor stays on the "new tab" button.

[chris fleizach]

Created attachment 87641 [details]
patch

[Darin Adler]

Comment on attachment 87641 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=87641&action=review

> Source/WebCore/page/FocusController.cpp:173
> +    bool advance = advanceFocus(direction, event, true);

I would name the local variable “didAdvanceFocus”.

> Source/WebCore/page/FocusController.cpp:179
> +    // If focus is being set initially, accessibility needs to be informed that system focus has moved 
> +    // into the web area again, even if focus did not change within WebCore. PostNotification is called instead
> +    // of handleFocusedUIElementChanged, because this will send the notification even if the element is the same.
> +    if (AXObjectCache::accessibilityEnabled())
> +        focusedOrMainFrame()->document()->axObjectCache()->postNotification(focusedOrMainFrame()->document()->renderer(), AXObjectCache::AXFocusedUIElementChanged, true);

Is it correct to do this even if advanceFocus returned false?

[chris fleizach]

> > Source/WebCore/page/FocusController.cpp:179
> > +    // If focus is being set initially, accessibility needs to be informed that system focus has moved 
> > +    // into the web area again, even if focus did not change within WebCore. PostNotification is called instead
> > +    // of handleFocusedUIElementChanged, because this will send the notification even if the element is the same.
> > +    if (AXObjectCache::accessibilityEnabled())
> > +        focusedOrMainFrame()->document()->axObjectCache()->postNotification(focusedOrMainFrame()->document()->renderer(), AXObjectCache::AXFocusedUIElementChanged, true);
> 
> Is it correct to do this even if advanceFocus returned false?

I believe so, because we want to inform that focus is now in the web area, even if it did not move. 

The consequence of this not being correct is minimal since the focused UI element will be the one that is already focused and the user won't see any difference.

[chris fleizach]

http://trac.webkit.org/changeset/82525