Bug 57494 - Update Windows production build logic for new production configurations
Summary: Update Windows production build logic for new production configurations
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Steve Falkenburg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-30 12:16 PDT by Steve Falkenburg
Modified: 2011-03-30 13:38 PDT (History)
1 user (show)

See Also:

Attachments
Patch (30.15 KB, patch)
2011-03-30 12:22 PDT, Steve Falkenburg 		aroben: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Falkenburg 2011-03-30 12:16:24 PDT 
Update Windows production build logic for new production configurations
Comment 1 Steve Falkenburg 2011-03-30 12:22:15 PDT 
Created attachment 87596 [details]
Patch
Comment 2 Adam Roben (:aroben) 2011-03-30 12:40:42 PDT 
Comment on attachment 87596 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=87596&action=review

> WebKitLibraries/win/tools/vsprops/production.vsprops:17
> +		PreprocessorDefinitions="NDEBUG;__PRODUCTION__=1"

Do we really need the NDEBUG here?
Comment 3 Steve Falkenburg 2011-03-30 13:38:29 PDT 
Committed r82493: <http://trac.webkit.org/changeset/82493>