Bug 57489 - Mac builders built 82512, but shouldn't have
Summary: Mac builders built 82512, but shouldn't have
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2011-03-30 11:41 PDT by Adam Roben (:aroben)
Modified: 2011-04-01 07:10 PDT (History)
0 users

See Also:

Mark .vcproj/.vsprops/.sln files as being Windows-only (2.67 KB, patch)
2011-04-01 06:57 PDT, Adam Roben (:aroben)
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2011-03-30 11:41:20 PDT
r82477 changed a bunch of Windows-only files, but the Mac builders built it anyway. They should have skipped this revision. For example, <http://build.webkit.org/builders/Leopard%20Intel%20Release%20%28Build%29/builds/32497>.
Comment 1 Adam Roben (:aroben) 2011-04-01 06:51:36 PDT
Turns out r82477 touched webkitdirs.pm, so triggering a build was valid. But it looks like the Mac builders will build in response to any .vcproj/.vsprops/.sln file change, and we should fix that.

r82512 is a better example.
Comment 2 Adam Roben (:aroben) 2011-04-01 06:57:51 PDT
Created attachment 87854 [details]
Mark .vcproj/.vsprops/.sln files as being Windows-only
Comment 3 Adam Roben (:aroben) 2011-04-01 07:10:49 PDT
Committed r82679: <http://trac.webkit.org/changeset/82679>