RESOLVED FIXED 57489
Mac builders built 82512, but shouldn't have 
https://bugs.webkit.org/show_bug.cgi?id=57489
Summary Mac builders built 82512, but shouldn't have
Adam Roben (:aroben)
Reported 2011-03-30 11:41:20 PDT
r82477 changed a bunch of Windows-only files, but the Mac builders built it anyway. They should have skipped this revision. For example, <http://build.webkit.org/builders/Leopard%20Intel%20Release%20%28Build%29/builds/32497>.
Attachments
Mark .vcproj/.vsprops/.sln files as being Windows-only (2.67 KB, patch)
2011-04-01 06:57 PDT, Adam Roben (:aroben) 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Roben (:aroben)
Comment 1 2011-04-01 06:51:36 PDT
Turns out r82477 touched webkitdirs.pm, so triggering a build was valid. But it looks like the Mac builders will build in response to any .vcproj/.vsprops/.sln file change, and we should fix that. r82512 is a better example.
Adam Roben (:aroben)
Comment 2 2011-04-01 06:57:51 PDT
Created attachment 87854 [details] Mark .vcproj/.vsprops/.sln files as being Windows-only
Adam Roben (:aroben)
Comment 3 2011-04-01 07:10:49 PDT
Committed r82679: <http://trac.webkit.org/changeset/82679>
Note You need to log in before you can comment on or make changes to this bug.