WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED WONTFIX
57484
[chromium] Clean up compositor layer dirty state
https://bugs.webkit.org/show_bug.cgi?id=57484
Summary
[chromium] Clean up compositor layer dirty state
Adrienne Walker
Reported
2011-03-30 11:33:21 PDT
Here's the state of things: there are currently a number of different ways to track dirtiness on LayerChromium (m_dirtyRect and m_contentsDirty). There's also setNeedsDisplay(FloatRect), setNeedsDisplay(), invalidateRect(FloatRect), and resetNeedsDisplay(). A bunch of layers also skip these functions and touch m_dirtyRect directly, but don't touch m_contentsDirty. On top of that, the tiler that content and image layers will own (a
Attachments
Add attachment
proposed patch, testcase, etc.
Adrienne Walker
Comment 1
2011-03-30 11:35:05 PDT
(Oops. Clicked on something that sent a half-finished bug-report.) Here's the state of things: there are currently a number of different ways to track dirtiness on LayerChromium (m_dirtyRect and m_contentsDirty). There's also setNeedsDisplay(FloatRect), setNeedsDisplay(), invalidateRect(FloatRect), and resetNeedsDisplay(). A bunch of layers also skip these functions and touch m_dirtyRect directly, but don't touch m_contentsDirty. It also looks like resetNeedsDisplay is never called (but probably should be) and invalidateRect is a no-op virtual that nothing ever overrides. On top of that, the tiler that content and image layers will own (see
bug 57113
) track their own separate dirty rect. This should get cleaned up and sorted out.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug