Bug 57484 - [chromium] Clean up compositor layer dirty state
Summary: [chromium] Clean up compositor layer dirty state
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Adrienne Walker
URL:
Keywords:
Depends on: 57113
Blocks:
  Show dependency tree / graph
 
Reported: 2011-03-30 11:33 PDT by Adrienne Walker
Modified: 2013-04-08 11:16 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adrienne Walker 2011-03-30 11:33:21 PDT 
Here's the state of things: there are currently a number of different ways to track dirtiness on LayerChromium (m_dirtyRect and m_contentsDirty).  There's also setNeedsDisplay(FloatRect), setNeedsDisplay(), invalidateRect(FloatRect), and resetNeedsDisplay().  A bunch of layers also skip these functions and touch m_dirtyRect directly, but don't touch m_contentsDirty.

On top of that, the tiler that content and image layers will own (a
Comment 1 Adrienne Walker 2011-03-30 11:35:05 PDT 
(Oops.  Clicked on something that sent a half-finished bug-report.)

Here's the state of things: there are currently a number of different ways to track dirtiness on LayerChromium (m_dirtyRect and m_contentsDirty).  There's also setNeedsDisplay(FloatRect), setNeedsDisplay(), invalidateRect(FloatRect), and resetNeedsDisplay().  A bunch of layers also skip these functions and touch m_dirtyRect directly, but don't touch m_contentsDirty.  It also looks like resetNeedsDisplay is never called (but probably should be) and invalidateRect is a no-op virtual that nothing ever overrides.

On top of that, the tiler that content and image layers will own (see bug 57113) track their own separate dirty rect.

This should get cleaned up and sorted out.