Bug 57457 - Add support for parsing unicode-bidi:plaintext
Summary: Add support for parsing unicode-bidi:plaintext
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 57482
Blocks: 50949
  Show dependency treegraph
 
Reported: 2011-03-30 08:01 PDT by Ofri Wolfus
Modified: 2011-03-30 12:02 PDT (History)
3 users (show)

See Also:


Attachments
Patch (6.40 KB, patch)
2011-03-30 08:06 PDT, Ofri Wolfus
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ofri Wolfus 2011-03-30 08:01:12 PDT
Add support for parsing unicode-bidi:plaintext
Comment 1 Ofri Wolfus 2011-03-30 08:06:27 PDT
Created attachment 87538 [details]
Patch
Comment 2 WebKit Review Bot 2011-03-30 08:09:55 PDT
Attachment 87538 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/css3..." exit_code: 1

Source/WebCore/rendering/style/RenderStyle.h:258:  _unicodeBidi is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 1 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Eric Seidel (no email) 2011-03-30 08:23:36 PDT
Comment on attachment 87538 [details]
Patch

LGTM.
Comment 4 WebKit Commit Bot 2011-03-30 10:20:42 PDT
Comment on attachment 87538 [details]
Patch

Clearing flags on attachment: 87538

Committed r82463: <http://trac.webkit.org/changeset/82463>
Comment 5 WebKit Commit Bot 2011-03-30 10:20:48 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Eric Seidel (no email) 2011-03-30 11:41:40 PDT
I suspect this is hitting an ASSERT in the BidiResolver code which I ran across today.  Ofri and I can look into it tomorrow.
Comment 7 Eric Seidel (no email) 2011-03-30 12:02:18 PDT
Hmm... the backtrac was not as expected:
 http://build.webkit.org/results/Leopard%20Intel%20Debug%20%28Tests%29/r82463%20(28266)/editing/deleting/5408255-crash-log.txt