RESOLVED FIXED 57444
Web Inspector: remove unnecessary newBody output parameter from editScriptSource protocol method. 
https://bugs.webkit.org/show_bug.cgi?id=57444
Summary Web Inspector: remove unnecessary newBody output parameter from editScriptSou...
Pavel Podivilov
Reported 2011-03-30 05:20:47 PDT
Web Inspector: remove unnecessary newBody output parameter from editScriptSource protocol method.
Attachments
Patch. (17.40 KB, patch)
2011-03-30 05:21 PDT, Pavel Podivilov 		pfeldman: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pavel Podivilov
Comment 1 2011-03-30 05:21:40 PDT
Created attachment 87508 [details] Patch.
Pavel Feldman
Comment 2 2011-03-30 08:25:48 PDT
Comment on attachment 87508 [details] Patch. View in context: https://bugs.webkit.org/attachment.cgi?id=87508&action=review > Source/WebCore/inspector/Inspector.json:1195 > { "name": "stackFrames", "type": "array", "items": { "$ref" : "CallFrame"}, "description": "New stack trace in case editing has happened while VM was stopped." } could you call this variable callFrames instead of stackFrames while you are there?
Pavel Podivilov
Comment 3 2011-03-31 09:37:35 PDT
Committed r82590: <http://trac.webkit.org/changeset/82590>
WebKit Review Bot
Comment 4 2011-03-31 10:34:03 PDT
http://trac.webkit.org/changeset/82590 might have broken Qt Linux Release The following tests are not passing: fast/dom/HTMLMeterElement/meter-boundary-values.html fast/dom/HTMLMeterElement/meter-optimums.html fast/dom/HTMLMeterElement/meter-styles-changing-pseudo.html fast/dom/HTMLMeterElement/meter-styles.html
Note You need to log in before you can comment on or make changes to this bug.