Bug 57442 - REGRESSION(r82419): New pixel test failure fast/box-shadow/basic-shadows.html
Summary: REGRESSION(r82419): New pixel test failure fast/box-shadow/basic-shadows.html
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-30 05:04 PDT by Yuta Kitamura
Modified: 2011-03-30 10:10 PDT (History)
4 users (show)

See Also:

Attachments
Actual result (55.80 KB, image/png)
2011-03-30 05:05 PDT, Yuta Kitamura 		no flags Details
Expected result (55.29 KB, image/png)
2011-03-30 05:06 PDT, Yuta Kitamura 		no flags Details
Patch (1.38 KB, patch)
2011-03-30 08:35 PDT, Yael 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yuta Kitamura 2011-03-30 05:04:06 PDT 
fast/box-shadow/basic-shadows.html started to fail since r82419. See attached screenshots.
Comment 1 Yuta Kitamura 2011-03-30 05:05:42 PDT 
Created attachment 87505 [details]
Actual result
Comment 2 Yuta Kitamura 2011-03-30 05:06:11 PDT 
Created attachment 87506 [details]
Expected result
Comment 3 Yael 2011-03-30 05:53:30 PDT 
Sorry about the regression. What port is doing that? I don't see it on the mac build bot.
Comment 4 Yuta Kitamura 2011-03-30 05:58:20 PDT 
At least, all Chromium bots are affected. I think this can be reproduced on all ports.

The bots in WebKit waterfall do not run pixel tests. You can try it (even on Apple's Mac port) manually with:

  run-webkit-tests -p --tolerance=0 fast/box-shadow/basic-shadows.html
Comment 5 Yael 2011-03-30 08:35:46 PDT 
Created attachment 87542 [details]
Patch

Don't consider br as text when evaluating the logically last run to decide if it is last for its renderer.
Comment 6 Eric Seidel (no email) 2011-03-30 08:38:00 PDT 
Comment on attachment 87542 [details]
Patch

OK.  Sad this is only covered by pixel tests.
Comment 7 WebKit Commit Bot 2011-03-30 10:10:46 PDT 
Comment on attachment 87542 [details]
Patch

Clearing flags on attachment: 87542

Committed r82461: <http://trac.webkit.org/changeset/82461>
Comment 8 WebKit Commit Bot 2011-03-30 10:10:50 PDT 
All reviewed patches have been landed.  Closing bug.