RESOLVED FIXED 57432
Split out handling of trailing spaces from layoutInlineChildren 
https://bugs.webkit.org/show_bug.cgi?id=57432
Summary Split out handling of trailing spaces from layoutInlineChildren
Eric Seidel (no email)
Reported Wednesday, March 30, 2011 10:09:44 AM UTC
Split out handling of trailing spaces from layoutInlineChildren
Attachments
Patch (7.70 KB, patch)
2011-03-30 02:11 PDT, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
Patch for landing (7.65 KB, patch)
2011-04-03 00:29 PDT, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 Wednesday, March 30, 2011 10:11:29 AM UTC
Created attachment 87484 [details] Patch
mitz
Comment 2 Wednesday, March 30, 2011 4:10:45 PM UTC
Comment on attachment 87484 [details] Patch Nice. I would have made this a static function with a const RenderBlock* parameter.
Eric Seidel (no email)
Comment 3 Wednesday, March 30, 2011 4:21:59 PM UTC
Comment on attachment 87484 [details] Patch (In reply to comment #2) > (From update of attachment 87484 [details]) > Nice. I would have made this a static function with a const RenderBlock* parameter. I thought about that. But this reads cleaner (but has more perf risk). If the PLT bots tell me it's slower I'll fix to do just that. Thanks!
WebKit Commit Bot
Comment 4 Wednesday, March 30, 2011 4:24:23 PM UTC
Comment on attachment 87484 [details] Patch Rejecting attachment 87484 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-4', 'apply-..." exit_code: 2 Last 500 characters of output: s). patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/rendering/RenderBlock.h patching file Source/WebCore/rendering/RenderBlockLineLayout.cpp Hunk #1 FAILED at 608. Hunk #2 succeeded at 853 (offset 21 lines). 1 out of 2 hunks FAILED -- saving rejects to file Source/WebCore/rendering/RenderBlockLineLayout.cpp.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Dan Bernstein', u'--fo..." exit_code: 1 Full output: http://queues.webkit.org/results/8298330
Eric Seidel (no email)
Comment 5 Sunday, April 3, 2011 8:29:30 AM UTC
Created attachment 88001 [details] Patch for landing
WebKit Commit Bot
Comment 6 Sunday, April 3, 2011 9:30:00 AM UTC
Comment on attachment 88001 [details] Patch for landing Clearing flags on attachment: 88001 Committed r82792: <http://trac.webkit.org/changeset/82792>
WebKit Commit Bot
Comment 7 Sunday, April 3, 2011 9:30:05 AM UTC
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.