RESOLVED FIXED 57430
[Chromium] DumpRenderTree: Implement LayoutTestController::setPluginsEnabled 
https://bugs.webkit.org/show_bug.cgi?id=57430
Summary [Chromium] DumpRenderTree: Implement LayoutTestController::setPluginsEnabled
Yuta Kitamura
Reported 2011-03-30 00:42:41 PDT
http://trac.webkit.org/changeset/82399 adds dependency to LayoutTestController::setPluginsEnabled().
Attachments
Patch (4.82 KB, patch)
2011-03-30 01:55 PDT, Yuta Kitamura 		tkent: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yuta Kitamura
Comment 1 2011-03-30 01:55:26 PDT
Created attachment 87482 [details] Patch
Yuta Kitamura
Comment 2 2011-03-30 01:59:08 PDT
Could anybody review this?
Kent Tamura
Comment 3 2011-03-30 02:06:20 PDT
Comment on attachment 87482 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=87482&action=review > Tools/DumpRenderTree/chromium/LayoutTestController.cpp:1702 > + bool pluginsEnabled = arguments[0].toBoolean(); > + m_shell->preferences()->pluginsEnabled = pluginsEnabled; nit: You can omit the variable pluginsEnabled.
Yuta Kitamura
Comment 4 2011-03-30 02:10:39 PDT
(In reply to comment #3) > nit: You can omit the variable pluginsEnabled. Thanks, I have fixed it locally and will commit manually.
Yuta Kitamura
Comment 5 2011-03-30 02:17:09 PDT
Committed r82416: <http://trac.webkit.org/changeset/82416>
Note You need to log in before you can comment on or make changes to this bug.