Bug 57430 - [Chromium] DumpRenderTree: Implement LayoutTestController::setPluginsEnabled
Summary: [Chromium] DumpRenderTree: Implement LayoutTestController::setPluginsEnabled
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-30 00:42 PDT by Yuta Kitamura
Modified: 2011-03-30 02:17 PDT (History)
2 users (show)

See Also:

Attachments
Patch (4.82 KB, patch)
2011-03-30 01:55 PDT, Yuta Kitamura 		tkent: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yuta Kitamura 2011-03-30 00:42:41 PDT 
http://trac.webkit.org/changeset/82399 adds dependency to LayoutTestController::setPluginsEnabled().
Comment 1 Yuta Kitamura 2011-03-30 01:55:26 PDT 
Created attachment 87482 [details]
Patch
Comment 2 Yuta Kitamura 2011-03-30 01:59:08 PDT 
Could anybody review this?
Comment 3 Kent Tamura 2011-03-30 02:06:20 PDT 
Comment on attachment 87482 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=87482&action=review

> Tools/DumpRenderTree/chromium/LayoutTestController.cpp:1702
> +        bool pluginsEnabled = arguments[0].toBoolean();
> +        m_shell->preferences()->pluginsEnabled = pluginsEnabled;

nit: You can omit the variable pluginsEnabled.
Comment 4 Yuta Kitamura 2011-03-30 02:10:39 PDT 
(In reply to comment #3)
> nit: You can omit the variable pluginsEnabled.

Thanks, I have fixed it locally and will commit manually.
Comment 5 Yuta Kitamura 2011-03-30 02:17:09 PDT 
Committed r82416: <http://trac.webkit.org/changeset/82416>