NEW 57427
webkit-patch mac-ews - build results interposed with SVN login prompt 
https://bugs.webkit.org/show_bug.cgi?id=57427
Summary webkit-patch mac-ews - build results interposed with SVN login prompt
Daniel Bates
Reported 2011-03-30 00:00:06 PDT
When webkit-patch mac-ews finished building a patch it printed to standard output that the build Passed which was interposed with the SVN login prompt. Here's a snippet: [[ ... Could not find a keychain entry for bugs.webkit.org. dbates@webkit.org bugs.webkit.org password for dbates@webkit.org: Logging in as dbates@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=87434&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=56730&ctype=xml Processing 1 patch from 1 bug. Updating working directory Processing patch 87434 from bug 56730. Building WebKit bugs.webkit.org login: Pass webkitpy.common.net.statusserver: [INFO] Releasing work item 87434 from mac-ews Fetching: https://bugs.webkit.org/attachment.cgi?id=87444&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=57409&ctype=xml Reading Keychain for bugs.webkit.org account and password. Click "Allow" to continue... Could not find a keychain entry for bugs.webkit.org. ... ]] In particular, notice the line "bugs.webkit.org login: Pass". The build result is interposed with the SVN login prompt. From looking at the output of ps(1) I have two webkit-patch processes: 971 ttys000 0:00.97 python Tools/Scripts/webkit-patch --status-host=queues.webkit.org --bot-id=dbates-atlas build-attachment --port=mac --build --build-style=release --force-clean --quiet --non-interactive 87467 48087 ttys000 0:01.18 python Tools/Scripts/webkit-patch --bot-id=dbates-atlas mac-ews I haven't looked through the code yet. I take it that both processes are printing to standard output. Hence the interposed output.
Attachments
Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2011-03-30 00:17:00 PDT
Yes. There's a master and child process. These commands are not really meant to be run interactively and assume you have your SVN credentials cached. :(
Note You need to log in before you can comment on or make changes to this bug.