Bug 57425 - make webkit-patch upload respect -d
Summary: make webkit-patch upload respect -d
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Maciej Stachowiak
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-29 23:45 PDT by Maciej Stachowiak
Modified: 2011-03-30 01:08 PDT (History)
2 users (show)

See Also:


Attachments
Patch (1.10 KB, patch)
2011-03-29 23:45 PDT, Maciej Stachowiak
no flags Details | Formatted Diff | Diff
Patch (3.48 KB, patch)
2011-03-30 00:46 PDT, Maciej Stachowiak
abarth: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Maciej Stachowiak 2011-03-29 23:45:10 PDT
make webkit-patch upload respect -d
Comment 1 Maciej Stachowiak 2011-03-29 23:45:28 PDT
Created attachment 87470 [details]
Patch
Comment 2 Maciej Stachowiak 2011-03-30 00:46:42 PDT
Created attachment 87478 [details]
Patch
Comment 3 Adam Barth 2011-03-30 00:55:05 PDT
Comment on attachment 87478 [details]
Patch

This looks correct.  Ideally we would add a test as well.
Comment 4 Maciej Stachowiak 2011-03-30 00:56:25 PDT
Committed r82407: <http://trac.webkit.org/changeset/82407>
Comment 5 Eric Seidel (no email) 2011-03-30 01:04:01 PDT
Be strong abarth!  /me is very sad at lack of testing. :(
Comment 6 Maciej Stachowiak 2011-03-30 01:05:14 PDT
I will learn how to operate the Python unit tests some day. scm_unitests.py boggles my mind at present.
Comment 7 Eric Seidel (no email) 2011-03-30 01:08:23 PDT
scm_unitteset.py is our oldest and worst unit test file.

But you can run a single class of tests with:

test-webkitpy webkitpy.common.checkout.scm_unittest.SCMClassTests

or even just a single test:

test-webkitpy webkitpy.common.checkout.scm_unittest.SCMClassTests.test_run_command_with_pipe