Bug 57415 - Expose shadowRoot to JSC in DumpRenderTree tests
Summary: Expose shadowRoot to JSC in DumpRenderTree tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 56573
  Show dependency tree / graph
 
Reported: 2011-03-29 19:03 PDT by Dominic Cooney
Modified: 2011-03-30 20:35 PDT (History)
9 users (show)

See Also:

Attachments
Patch (14.07 KB, patch)
2011-03-29 19:45 PDT, Dominic Cooney 		no flags Details | Formatted Diff | Diff
Patch (14.71 KB, patch)
2011-03-30 10:52 PDT, Dominic Cooney 		no flags Details | Formatted Diff | Diff
Patch (14.80 KB, patch)
2011-03-30 13:04 PDT, Dominic Cooney 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dominic Cooney 2011-03-29 19:03:53 PDT 
JavaScript can not access shadow DOM, however DumpRenderTree tests should be able to access shadow DOM to make programmatic assertions about shadow DOM.

I’m filing this to track the Mac port.
Comment 1 Dominic Cooney 2011-03-29 19:45:02 PDT 
Created attachment 87454 [details]
Patch
Comment 2 Dominic Cooney 2011-03-29 19:46:39 PDT 
Comment on attachment 87454 [details]
Patch

This does a drive-by on keygen.html to exercise the new DRT functionality. Thoughts? (OK? Don’t bother? Separate test?)
Comment 3 Collabora GTK+ EWS bot 2011-03-29 21:36:27 PDT 
Attachment 87454 [details] did not build on gtk:
Build output: http://queues.webkit.org/results/8285609
Comment 4 Dominic Cooney 2011-03-29 22:58:56 PDT 
Comment on attachment 87454 [details]
Patch

Oops—broke GTK. I will have another go at this.
Comment 5 Dominic Cooney 2011-03-30 10:52:36 PDT 
Created attachment 87573 [details]
Patch
Comment 6 Dominic Cooney 2011-03-30 13:04:55 PDT 
Created attachment 87601 [details]
Patch
Comment 7 Dimitri Glazkov (Google) 2011-03-30 16:26:33 PDT 
Comment on attachment 87601 [details]
Patch

yay us. Let's go.
Comment 8 WebKit Commit Bot 2011-03-30 19:34:02 PDT 
Comment on attachment 87601 [details]
Patch

Clearing flags on attachment: 87601

Committed r82536: <http://trac.webkit.org/changeset/82536>
Comment 9 WebKit Commit Bot 2011-03-30 19:34:08 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 10 WebKit Review Bot 2011-03-30 20:35:56 PDT 
http://trac.webkit.org/changeset/82536 might have broken GTK Linux 32-bit Debug