Bug 57406 - Add default localization strategy that can be shared by WebKit1 and WebKit2
Summary: Add default localization strategy that can be shared by WebKit1 and WebKit2
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-29 17:29 PDT by Sam Weinig
Modified: 2011-03-30 10:29 PDT (History)
1 user (show)

See Also:

Attachments
Patch (149.88 KB, patch)
2011-03-29 17:43 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (150.67 KB, patch)
2011-03-30 10:16 PDT, Sam Weinig 		andersca: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2011-03-29 17:29:41 PDT 
Add default localization strategy that can be shared by WebKit1 and WebKit2
Comment 1 Sam Weinig 2011-03-29 17:43:40 PDT 
Created attachment 87442 [details]
Patch
Comment 2 WebKit Review Bot 2011-03-29 17:47:24 PDT 
Attachment 87442 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/Android.mk', u'Source/WebCo..." exit_code: 1

Source/WebKit2/ChangeLog:28:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Source/WebCore/platform/DefaultLocalizationStrategy.h:168:  The parameter name "size" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 2 in 22 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Sam Weinig 2011-03-30 10:16:37 PDT 
Created attachment 87560 [details]
Patch
Comment 4 Sam Weinig 2011-03-30 10:29:07 PDT 
Landed in r82465.