Bug 57397 - ShareableBitmap needs its own Handle type
Summary: ShareableBitmap needs its own Handle type
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adam Roben (:aroben)
Depends on:
Blocks: 57388
  Show dependency treegraph
Reported: 2011-03-29 16:01 PDT by Adam Roben (:aroben)
Modified: 2011-03-30 07:43 PDT (History)
2 users (show)

See Also:

Patch (37.61 KB, patch)
2011-03-29 16:01 PDT, Adam Roben (:aroben)
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2011-03-29 16:01:10 PDT
ShareableBitmap needs its own Handle type
Comment 1 Adam Roben (:aroben) 2011-03-29 16:01:53 PDT
Created attachment 87424 [details]
Comment 2 WebKit Review Bot 2011-03-29 16:04:49 PDT
Attachment 87424 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1

Source/WebKit2/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 24 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Adam Roben (:aroben) 2011-03-29 16:11:45 PDT
Comment on attachment 87424 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=87424&action=review

>> Source/WebKit2/ChangeLog:1
>> +2011-03-29  Adam Roben  <aroben@apple.com>
> ChangeLog entry has no bug number  [changelog/bugnumber] [5]

I guess check-webkit-style doesn't like my non-standard way of including bug URLs in ChangeLogs.
Comment 4 Adam Roben (:aroben) 2011-03-30 07:43:28 PDT
Committed r82441: <http://trac.webkit.org/changeset/82441>