Bug 57379 - Clean up WK1 key event handling logic
Summary: Clean up WK1 key event handling logic
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.6
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-29 13:00 PDT by Alexey Proskuryakov
Modified: 2011-03-29 14:13 PDT (History)
0 users

See Also:

Attachments
proposed patch (16.88 KB, patch)
2011-03-29 13:58 PDT, Alexey Proskuryakov 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2011-03-29 13:00:57 PDT 
I want to make the code less confusing to make porting to WK2 easier.
Comment 1 Alexey Proskuryakov 2011-03-29 13:58:42 PDT 
Created attachment 87405 [details]
proposed patch
Comment 2 Darin Adler 2011-03-29 14:02:21 PDT 
Comment on attachment 87405 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=87405&action=review

> Source/WebKit/mac/WebView/WebHTMLView.mm:5446
> +    // Avoid an infinite loop that would occur if executing a command saved it back.

I don’t understand the phrase “saved it back”.

> Source/WebKit/mac/WebView/WebHTMLView.mm:5453
> +        if (commands[i].commandName == "insertText:")

I’d be happier if we didn’t have multiple copies of the insertText: selector string, and instead used a constant.
Comment 3 Alexey Proskuryakov 2011-03-29 14:13:13 PDT 
Committed <http://trac.webkit.org/changeset/82320>.