RESOLVED FIXED Bug 57379
Clean up WK1 key event handling logic 
https://bugs.webkit.org/show_bug.cgi?id=57379
Summary Clean up WK1 key event handling logic
Alexey Proskuryakov
Reported 2011-03-29 13:00:57 PDT
I want to make the code less confusing to make porting to WK2 easier.
Attachments
proposed patch (16.88 KB, patch)
2011-03-29 13:58 PDT, Alexey Proskuryakov 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2011-03-29 13:58:42 PDT
Created attachment 87405 [details] proposed patch
Darin Adler
Comment 2 2011-03-29 14:02:21 PDT
Comment on attachment 87405 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=87405&action=review > Source/WebKit/mac/WebView/WebHTMLView.mm:5446 > + // Avoid an infinite loop that would occur if executing a command saved it back. I don’t understand the phrase “saved it back”. > Source/WebKit/mac/WebView/WebHTMLView.mm:5453 > + if (commands[i].commandName == "insertText:") I’d be happier if we didn’t have multiple copies of the insertText: selector string, and instead used a constant.
Alexey Proskuryakov
Comment 3 2011-03-29 14:13:13 PDT
Committed <http://trac.webkit.org/changeset/82320>.
Note You need to log in before you can comment on or make changes to this bug.