Bug 57377 - REGRESSION(r82295): This patch does not compile on Chromium (Requested by abarth|gardener on #webkit).
Summary: REGRESSION(r82295): This patch does not compile on Chromium (Requested by aba...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: WebKit Review Bot
URL:
Keywords:
Depends on:
Blocks: 47636
  Show dependency treegraph
 
Reported: 2011-03-29 12:13 PDT by WebKit Review Bot
Modified: 2011-03-29 12:39 PDT (History)
3 users (show)

See Also:


Attachments
ROLLOUT of r82295 (10.04 KB, patch)
2011-03-29 12:13 PDT, WebKit Review Bot
mario: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description WebKit Review Bot 2011-03-29 12:13:16 PDT
http://trac.webkit.org/changeset/82295 broke the build:
This patch does not compile on Chromium (Requested by abarth|gardener on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear
Comment 1 WebKit Review Bot 2011-03-29 12:13:44 PDT
Created attachment 87388 [details]
ROLLOUT of r82295

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID --ignore-builders

where ATTACHMENT_ID is the ID of this attachment.
Comment 2 Mario Sanchez Prada 2011-03-29 12:21:14 PDT
Comment on attachment 87388 [details]
ROLLOUT of r82295

Stopping the rollout by now. I'll try to find a fix for it quickly
Comment 3 chris fleizach 2011-03-29 12:27:40 PDT
(In reply to comment #2)
> (From update of attachment 87388 [details])
> Stopping the rollout by now. I'll try to find a fix for it quickly

This is because chromium duplicates internal webcore roles, a bad idea from the start
Comment 4 Mario Sanchez Prada 2011-03-29 12:39:02 PDT
Committed r82300: <http://trac.webkit.org/changeset/82300>