RESOLVED FIXED 57375
cleanup rebaseline-chromium-webkit-tests 
https://bugs.webkit.org/show_bug.cgi?id=57375
Summary cleanup rebaseline-chromium-webkit-tests
Tony Chang
Reported 2011-03-29 12:07:31 PDT
cleanup rebaseline-chromium-webkit-tests
Attachments
Patch (20.29 KB, patch)
2011-03-29 12:26 PDT, Tony Chang 		eric: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tony Chang
Comment 1 2011-03-29 12:26:04 PDT
Created attachment 87391 [details] Patch
Tony Chang
Comment 2 2011-03-29 12:27:16 PDT
No code change, just refactoring.
Eric Seidel (no email)
Comment 3 2011-03-29 13:03:19 PDT
Comment on attachment 87391 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=87391&action=review > Tools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:364 > + def _extract_and_add_new_baseline(self, test, zip_file): This still needs more splitting. :) > Tools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:398 > + if 0 != self._scm.add(expected_fullpath, return_exit_code=True): 0? > Tools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:459 > + else: webkit doens't else after return.
Tony Chang
Comment 4 2011-03-29 14:21:10 PDT
Committed r82322: <http://trac.webkit.org/changeset/82322>
Note You need to log in before you can comment on or make changes to this bug.