Bug 57375 - cleanup rebaseline-chromium-webkit-tests
Summary: cleanup rebaseline-chromium-webkit-tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Tony Chang
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-29 12:07 PDT by Tony Chang
Modified: 2011-03-29 14:21 PDT (History)
3 users (show)

See Also:

Attachments
Patch (20.29 KB, patch)
2011-03-29 12:26 PDT, Tony Chang 		eric: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Chang 2011-03-29 12:07:31 PDT 
cleanup rebaseline-chromium-webkit-tests
Comment 1 Tony Chang 2011-03-29 12:26:04 PDT 
Created attachment 87391 [details]
Patch
Comment 2 Tony Chang 2011-03-29 12:27:16 PDT 
No code change, just refactoring.
Comment 3 Eric Seidel (no email) 2011-03-29 13:03:19 PDT 
Comment on attachment 87391 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=87391&action=review

> Tools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:364
> +    def _extract_and_add_new_baseline(self, test, zip_file):

This still needs more splitting. :)

> Tools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:398
> +            if 0 != self._scm.add(expected_fullpath, return_exit_code=True):

0?

> Tools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:459
> +            else:

webkit doens't else after return.
Comment 4 Tony Chang 2011-03-29 14:21:10 PDT 
Committed r82322: <http://trac.webkit.org/changeset/82322>