Bug 57362 - [GTK] implement LayoutTestController::setWillSendRequestReturnsNull
Summary: [GTK] implement LayoutTestController::setWillSendRequestReturnsNull
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-29 10:47 PDT by Philippe Normand
Modified: 2011-03-31 09:56 PDT (History)
2 users (show)

See Also:

Attachments
Patch (2.71 KB, patch)
2011-03-31 08:57 PDT, Sergio Villar Senin 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2011-03-29 10:47:26 PDT 
Since bug 57325 was fixed fast/loader/onload-willSendRequest-null-for-frame.html started failing.
Our layout test controller should implement setWillSendRequestReturnsNull and not display the "Blocked access to external URL" message if this mehod is called before.

Will skip the failing test for now.
Comment 1 Sergio Villar Senin 2011-03-31 08:57:35 PDT 
Created attachment 87736 [details]
Patch
Comment 2 Martin Robinson 2011-03-31 09:01:46 PDT 
Comment on attachment 87736 [details]
Patch

Great stuff. You should also unskip fast/loader/onload-willSendRequest-null-for-script.html, fast/loader/willSendRequest-null-for-preload.html and http/tests/misc/will-send-request-returns-null-on-redirect.html which are also skipped because of this.
Comment 3 Sergio Villar Senin 2011-03-31 09:55:23 PDT 
I didn't finally unskip the other 3 because they need some extra stuff. Relabeled them in the Skipped file.

Committed r82591
Comment 4 Sergio Villar Senin 2011-03-31 09:56:14 PDT 
Comment on attachment 87736 [details]
Patch

Clearing flag