WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
57362
[GTK] implement LayoutTestController::setWillSendRequestReturnsNull
https://bugs.webkit.org/show_bug.cgi?id=57362
Summary
[GTK] implement LayoutTestController::setWillSendRequestReturnsNull
Philippe Normand
Reported
2011-03-29 10:47:26 PDT
Since
bug 57325
was fixed fast/loader/onload-willSendRequest-null-for-frame.html started failing. Our layout test controller should implement setWillSendRequestReturnsNull and not display the "Blocked access to external URL" message if this mehod is called before. Will skip the failing test for now.
Attachments
Patch
(2.71 KB, patch)
2011-03-31 08:57 PDT
,
Sergio Villar Senin
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Sergio Villar Senin
Comment 1
2011-03-31 08:57:35 PDT
Created
attachment 87736
[details]
Patch
Martin Robinson
Comment 2
2011-03-31 09:01:46 PDT
Comment on
attachment 87736
[details]
Patch Great stuff. You should also unskip fast/loader/onload-willSendRequest-null-for-script.html, fast/loader/willSendRequest-null-for-preload.html and http/tests/misc/will-send-request-returns-null-on-redirect.html which are also skipped because of this.
Sergio Villar Senin
Comment 3
2011-03-31 09:55:23 PDT
I didn't finally unskip the other 3 because they need some extra stuff. Relabeled them in the Skipped file. Committed
r82591
Sergio Villar Senin
Comment 4
2011-03-31 09:56:14 PDT
Comment on
attachment 87736
[details]
Patch Clearing flag
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug