Bug 57356 – test_runner2.py can crash due to undefined variable

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Adam Barth]

test_runner2.py can crash due to undefined variable

[Adam Barth]

Created attachment 87356 [details]
Patch

[Adam Barth]

Stack from http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Linux/builds/5027/steps/webkit_tests/logs/stdio :

2011-03-29 10:12:30,431 2611 test_runner2.py:189 INFO Exception raised, exiting
Traceback (most recent call last):
  File "/mnt/data/build/slave/Webkit_Linux/build/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 439, in <module>
    sys.exit(main())
  File "/mnt/data/build/slave/Webkit_Linux/build/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 434, in main
    return run(port_obj, options, args)
  File "/mnt/data/build/slave/Webkit_Linux/build/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 120, in run
    num_unexpected_results = runner.run(result_summary)
  File "/mnt/data/build/slave/Webkit_Linux/build/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/layout_package/test_runner.py", line 664, in run
    self._run_tests(self._test_files_list, result_summary))
  File "/mnt/data/build/slave/Webkit_Linux/build/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/layout_package/test_runner2.py", line 164, in _run_tests
    manager_connection.run_message_loop(delay_secs=1.0)
  File "/mnt/data/build/slave/Webkit_Linux/build/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/layout_package/message_broker2.py", line 192, in run_message_loop
    self._broker.run_message_loop(self._run_topic, self._client, delay_secs)
  File "/mnt/data/build/slave/Webkit_Linux/build/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/layout_package/message_broker2.py", line 128, in run_message_loop
    self._run_loop(topic_name, client, block=True, delay_secs=delay_secs)
  File "/mnt/data/build/slave/Webkit_Linux/build/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/layout_package/message_broker2.py", line 142, in _run_loop
    self._dispatch_message(msg, client)
  File "/mnt/data/build/slave/Webkit_Linux/build/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/layout_package/message_broker2.py", line 151, in _dispatch_message
    message_handler(message.src, *optargs)
  File "/mnt/data/build/slave/Webkit_Linux/build/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/layout_package/test_runner2.py", line 227, in handle_finished_test
    _log.error("%s unwedged", w.name)
NameError: global name 'w' is not defined

[Dirk Pranke]

The patch looks good; I guess it's a testament to the improvements in the threading code that we hadn't triggered this before. 

It is actually possible to test this through some careful manipulation of the thread scheduling; there are some tests in manager_worker_broker_unittest that are close to what you would need. I'll see if I can write a test for it just to get the coverage.

Thanks for fixing this!

[WebKit Commit Bot]

Comment on attachment 87356 [details]
Patch

Clearing flags on attachment: 87356

Committed r82329: <http://trac.webkit.org/changeset/82329>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.