WebKit2 has localizable strings, but update-webkit-localizable-strings was never updated to scan them.
Created attachment 87359 [details] Proposed Change
Comment on attachment 87359 [details] Proposed Change View in context: https://bugs.webkit.org/attachment.cgi?id=87359&action=review It seems weird that WebLocalizableStrings.h is copied from LoaderRunLoopCF.h. Is that a git thing? > Source/WebCore/platform/network/cf/LoaderRunLoopCF.h:32 > -#error This code is not needed on platforms other than Windows, because main thread's CFRunLoop can be used. > +#error This code is not needed on platforms other than Windows, because the CFRunLoop from the main thread can be used. This change seems unrelated.
Attachment 87359 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebKit2/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Tools/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Source/WebKit/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 4 in 18 files If any of these errors are false positives, please file a bug against check-webkit-style.
(In reply to comment #2) > (From update of attachment 87359 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=87359&action=review > > It seems weird that WebLocalizableStrings.h is copied from LoaderRunLoopCF.h. Is that a git thing? Yes, a weird git thing. > > Source/WebCore/platform/network/cf/LoaderRunLoopCF.h:32 > > -#error This code is not needed on platforms other than Windows, because main thread's CFRunLoop can be used. > > +#error This code is not needed on platforms other than Windows, because the CFRunLoop from the main thread can be used. > > This change seems unrelated. Not unrelated. extract-localizable-strings complain about the single quote, as mentioned in the ChangeLog.
Created attachment 87367 [details] Proposed Change (updated to TOT) Updated to TOT to get EWS feedback.
Comment on attachment 87367 [details] Proposed Change (updated to TOT) Apply r+ because the previous patch was r+ed by Sam.
Attachment 87367 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebKit2/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Tools/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Source/WebKit/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 4 in 18 files If any of these errors are false positives, please file a bug against check-webkit-style.
Attachment 87367 [details] did not build on win: Build output: http://queues.webkit.org/results/8274000
Landed in r82308 (with a fix for the failures seen in EWS.)