Bug 57354 - Make update-webkit-localizable-strings work with WebKit2
Summary: Make update-webkit-localizable-strings work with WebKit2
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-29 10:08 PDT by Timothy Hatcher
Modified: 2011-03-29 13:26 PDT (History)
4 users (show)

See Also:


Attachments
Proposed Change (63.00 KB, patch)
2011-03-29 10:30 PDT, Timothy Hatcher
sam: review+
timothy: commit-queue-
Details | Formatted Diff | Diff
Proposed Change (updated to TOT) (62.98 KB, patch)
2011-03-29 11:00 PDT, Timothy Hatcher
timothy: review+
timothy: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2011-03-29 10:08:46 PDT
WebKit2 has localizable strings, but update-webkit-localizable-strings was never updated to scan them.
Comment 1 Timothy Hatcher 2011-03-29 10:30:30 PDT
Created attachment 87359 [details]
Proposed Change
Comment 2 Sam Weinig 2011-03-29 10:34:59 PDT
Comment on attachment 87359 [details]
Proposed Change

View in context: https://bugs.webkit.org/attachment.cgi?id=87359&action=review

It seems weird that WebLocalizableStrings.h is copied from LoaderRunLoopCF.h. Is that a git thing?

> Source/WebCore/platform/network/cf/LoaderRunLoopCF.h:32
> -#error This code is not needed on platforms other than Windows, because main thread's CFRunLoop can be used.
> +#error This code is not needed on platforms other than Windows, because the CFRunLoop from the main thread can be used.

This change seems unrelated.
Comment 3 WebKit Review Bot 2011-03-29 10:35:35 PDT
Attachment 87359 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebKit2/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Tools/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Source/WebKit/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Source/WebCore/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 4 in 18 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Timothy Hatcher 2011-03-29 10:36:38 PDT
(In reply to comment #2)
> (From update of attachment 87359 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=87359&action=review
> 
> It seems weird that WebLocalizableStrings.h is copied from LoaderRunLoopCF.h. Is that a git thing?

Yes, a weird git thing.

> > Source/WebCore/platform/network/cf/LoaderRunLoopCF.h:32
> > -#error This code is not needed on platforms other than Windows, because main thread's CFRunLoop can be used.
> > +#error This code is not needed on platforms other than Windows, because the CFRunLoop from the main thread can be used.
> 
> This change seems unrelated.

Not unrelated. extract-localizable-strings complain about the single quote, as mentioned in the ChangeLog.
Comment 5 Timothy Hatcher 2011-03-29 11:00:55 PDT
Created attachment 87367 [details]
Proposed Change (updated to TOT)

Updated to TOT to get EWS feedback.
Comment 6 Timothy Hatcher 2011-03-29 11:02:00 PDT
Comment on attachment 87367 [details]
Proposed Change (updated to TOT)

Apply r+ because the previous patch was r+ed by Sam.
Comment 7 WebKit Review Bot 2011-03-29 11:03:26 PDT
Attachment 87367 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebKit2/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Tools/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Source/WebKit/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Source/WebCore/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 4 in 18 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 Build Bot 2011-03-29 12:24:32 PDT
Attachment 87367 [details] did not build on win:
Build output: http://queues.webkit.org/results/8274000
Comment 9 Timothy Hatcher 2011-03-29 13:26:07 PDT
Landed in r82308 (with a fix for the failures seen in EWS.)