MSVC 8.0 has a bug where enums in bitfields are treated as signed, which causes the value when you read them back out to be incorrect (see description in link). The style checker should prevent us from falling in this hole like I almost did.
We (somewhat famously) hit this bug early during the Safari Win bringup. Folks continue to hit it today. Making check-webkit-style catch it would be nifty.
fwiw, the code is here: http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py And I'm willing to give pointers (and reviews) to anyone who wants to add checks.
Created attachment 206786 [details] Patch
Any thoughts on the patch? David would you be interested in reviewing it?
Comment on attachment 206786 [details] Patch Looks OK.
Comment on attachment 206786 [details] Patch Clearing flags on attachment: 206786 Committed r171038: <http://trac.webkit.org/changeset/171038>
All reviewed patches have been landed. Closing bug.