Bug 57351 - Web Inspector: [Chromium] Remove exact retained size request in detailed heap snapshots
Summary: Web Inspector: [Chromium] Remove exact retained size request in detailed heap...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Mikhail Naganov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-29 09:33 PDT by Mikhail Naganov
Modified: 2011-03-30 00:12 PDT (History)
13 users (show)

See Also:

Attachments
patch (10.64 KB, patch)
2011-03-29 09:43 PDT, Mikhail Naganov 		pfeldman: review+
mnaganov: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mikhail Naganov 2011-03-29 09:33:38 PDT 
We currently have two kinds of retained memory sizes for object: "approximate" obtained using dominator tree, and "exact" calculated by reachable objects marking. It turns out, that in most cases these sizes are the same. I've checked a heap snapshot of GMail and have found no object for which "approximate" and "exact" sizes differ. I haven't found any proof that those sizes are always the same (nor a proof for the opposite statement). I suppose that in most practical cases they are the same, so it makes no sense bloating UI with "approximate" / "exact" separation.
Comment 1 Mikhail Naganov 2011-03-29 09:43:17 PDT 
Created attachment 87348 [details]
patch
Comment 2 Mikhail Naganov 2011-03-29 23:27:35 PDT 
Manually committed http://trac.webkit.org/changeset/82393

2011-03-29  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [Chromium] Remove exact retained size request in detailed heap snapshots.
        https://bugs.webkit.org/show_bug.cgi?id=57351

        * bindings/js/ScriptHeapSnapshot.h:
        * bindings/v8/ScriptHeapSnapshot.cpp:
        * bindings/v8/ScriptHeapSnapshot.h:
        * inspector/Inspector.json:
        * inspector/InspectorProfilerAgent.cpp:
        * inspector/InspectorProfilerAgent.h:
        * inspector/front-end/DetailedHeapshotGridNodes.js:
        (WebInspector.HeapSnapshotGenericObjectNode):
        (WebInspector.HeapSnapshotGenericObjectNode.prototype.get data):
        * inspector/front-end/DetailedHeapshotView.js:
        (WebInspector.DetailedHeapshotView.prototype._mouseClickInContainmentGrid):
Comment 3 WebKit Review Bot 2011-03-30 00:12:29 PDT 
http://trac.webkit.org/changeset/82393 might have broken SnowLeopard Intel Release (WebKit2 Tests)