Bug 57351 – Web Inspector: [Chromium] Remove exact retained size request in detailed heap snapshots

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Mikhail Naganov]

We currently have two kinds of retained memory sizes for object: "approximate" obtained using dominator tree, and "exact" calculated by reachable objects marking. It turns out, that in most cases these sizes are the same. I've checked a heap snapshot of GMail and have found no object for which "approximate" and "exact" sizes differ. I haven't found any proof that those sizes are always the same (nor a proof for the opposite statement). I suppose that in most practical cases they are the same, so it makes no sense bloating UI with "approximate" / "exact" separation.

[Mikhail Naganov]

Created attachment 87348 [details]
patch

[Mikhail Naganov]

Manually committed http://trac.webkit.org/changeset/82393

2011-03-29  Mikhail Naganov  <[e-mail]>

        Reviewed by Pavel Feldman.

        Web Inspector: [Chromium] Remove exact retained size request in detailed heap snapshots.
        https://bugs.webkit.org/show_bug.cgi?id=57351

        * bindings/js/ScriptHeapSnapshot.h:
        * bindings/v8/ScriptHeapSnapshot.cpp:
        * bindings/v8/ScriptHeapSnapshot.h:
        * inspector/Inspector.json:
        * inspector/InspectorProfilerAgent.cpp:
        * inspector/InspectorProfilerAgent.h:
        * inspector/front-end/DetailedHeapshotGridNodes.js:
        (WebInspector.HeapSnapshotGenericObjectNode):
        (WebInspector.HeapSnapshotGenericObjectNode.prototype.get data):
        * inspector/front-end/DetailedHeapshotView.js:
        (WebInspector.DetailedHeapshotView.prototype._mouseClickInContainmentGrid):

[WebKit Review Bot]

http://trac.webkit.org/changeset/82393 might have broken SnowLeopard Intel Release (WebKit2 Tests)