Start to clean up BidiResolver::createBidiRunsForLine so that mere mortals can understand it
Created attachment 87316 [details] Patch
My understanding is that this code is super performance sensitive. However, hopefully the magic of the "inline" keyword will make this change a noop for perf. Then again, it's also possible if the compiler outlines this function things could get faster. :) In either case the Chromium PLT bots will let us know if any of these re-factorings make things slower (or faster!). This change should be perf-neutral. I just bring this up because this stuff is so hot.
Comment on attachment 87316 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=87316&action=review > Source/WebCore/platform/text/BidiResolver.h:525 > +inline void BidiResolver<Iterator, Run>::updateStatusLastFromCurrentDirection(WTF::Unicode::Direction dirCurrent) Nit: Should we rename dirCurrent to currentDirection?
The commit-queue encountered the following flaky tests while processing attachment 87316 [details]: fast/workers/storage/use-same-database-in-page-and-workers.html bug 50995 (author: dumi@chromium.org) The commit-queue is continuing to process your patch.
Comment on attachment 87316 [details] Patch Clearing flags on attachment: 87316 Committed r82297: <http://trac.webkit.org/changeset/82297>
All reviewed patches have been landed. Closing bug.