Bug 57335 – Clean up bidiNext by abstracting repeated code

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Eric Seidel (no email)]

Clean up bidiNext by abstracting repeated code

[Eric Seidel (no email)]

Created attachment 87310 [details]
Patch

[Ryosuke Niwa]

Comment on attachment 87310 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=87310&action=review

> Source/WebCore/rendering/InlineIterator.h:91
> +    using namespace WTF::Unicode;

Is it a common practice in WebKit to do "using namespace" inside a function?

> Source/WebCore/rendering/InlineIterator.h:111
> +    if (!resolver || !object->isRenderInline())

We should assert that object is not NULL or add an early exit.

[Eric Seidel (no email)]

(In reply to comment #2)
> (From update of attachment 87310 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=87310&action=review
> 
> > Source/WebCore/rendering/InlineIterator.h:91
> > +    using namespace WTF::Unicode;
> 
> Is it a common practice in WebKit to do "using namespace" inside a function?

No.  But it seems common in the bidi code.

> > Source/WebCore/rendering/InlineIterator.h:111
> > +    if (!resolver || !object->isRenderInline())
> 
> We should assert that object is not NULL or add an early exit.

OK.  will do.

[Eric Seidel (no email)]

Created attachment 87340 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 87340 [details]
Patch for landing

Clearing flags on attachment: 87340

Committed r82275: <http://trac.webkit.org/changeset/82275>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[WebKit Review Bot]

http://trac.webkit.org/changeset/82275 might have broken Leopard Intel Debug (Tests)