Clean up bidiNext by abstracting repeated code
Created attachment 87310 [details] Patch
Comment on attachment 87310 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=87310&action=review > Source/WebCore/rendering/InlineIterator.h:91 > + using namespace WTF::Unicode; Is it a common practice in WebKit to do "using namespace" inside a function? > Source/WebCore/rendering/InlineIterator.h:111 > + if (!resolver || !object->isRenderInline()) We should assert that object is not NULL or add an early exit.
(In reply to comment #2) > (From update of attachment 87310 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=87310&action=review > > > Source/WebCore/rendering/InlineIterator.h:91 > > + using namespace WTF::Unicode; > > Is it a common practice in WebKit to do "using namespace" inside a function? No. But it seems common in the bidi code. > > Source/WebCore/rendering/InlineIterator.h:111 > > + if (!resolver || !object->isRenderInline()) > > We should assert that object is not NULL or add an early exit. OK. will do.
Created attachment 87340 [details] Patch for landing
Comment on attachment 87340 [details] Patch for landing Clearing flags on attachment: 87340 Committed r82275: <http://trac.webkit.org/changeset/82275>
All reviewed patches have been landed. Closing bug.
http://trac.webkit.org/changeset/82275 might have broken Leopard Intel Debug (Tests)