Bug 57330 – onchange on text fields has an incoherent behavior in r82182

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Xavier Morel]

Go to http://www.quirksmode.org/dom/events/tests/change.html

Enter text in the text input (the one near "text label"), remove the text, tab out:

* Safari 5.0.4 triggers onchange every time
* Webkit r82182 triggers onchange *only the first time*, from the second time onwards no onchange triggers anymore

For reference, Opera and Chrome trigger onchange every time, Firefox never triggers onchange, no idea for MSIE.

[Alexey Proskuryakov]

Presumably due to r81978.

[Emil A Eklund]

I'll look into it.

[Emil A Eklund]

Created attachment 88996 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 88996 [details]
Patch

Rejecting attachment 88996 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-7', 'build-..." exit_code: 2

Last 500 characters of output:
ncoding/GBK ............
fast/encoding/dumpAsText .
fast/encoding/hebrew .......
fast/events .........................................................................................................................................................................
fast/events/onchange-text-form-field.html -> failed

Exiting early after 1 failures. 8202 tests run.
181.25s total testing time

8201 test cases (99%) succeeded
1 test case (<1%) had incorrect layout
4 test cases (<1%) had stderr output

Full output: http://queues.webkit.org/results/8402126

[WebKit Commit Bot]

Created attachment 89335 [details]
Archive of layout-test-results from cr-jail-7

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: cr-jail-7  Port: Mac  Platform: Mac OS X 10.6.6

[Emil A Eklund]

Created attachment 90432 [details]
Patch

Updated patch trying to fix the platform inconsistencies.

[Kent Tamura]

Comment on attachment 90432 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=90432&action=review

> LayoutTests/ChangeLog:12
> +
> +        * fast/events/onchange-text-form-field-expected.txt:
> +        * fast/events/onchange-text-form-field.html:
> +

ChangeLog has no entry for platform/gtk/fast/events/onchange-text-form-field-expected.txt.

[Emil A Eklund]

Created attachment 91730 [details]
Patch

Updated ChangeLog as suggested.

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 91730 [details]:

java/lc3/JSObject/ToObject-001.html bug 53091 (author: [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 91730 [details]
Patch

Clearing flags on attachment: 91730

Committed r85373: <http://trac.webkit.org/changeset/85373>