WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
57329
Web Inspector: InspectorDOMAgent has unnecessary dependency from InspectorAgent
https://bugs.webkit.org/show_bug.cgi?id=57329
Summary
Web Inspector: InspectorDOMAgent has unnecessary dependency from InspectorAgent
Ilya Tikhonovsky
Reported
Tuesday, March 29, 2011 1:14:26 PM UTC
%subj% It was introduced at
r81771
.
Attachments
[patch] initial version
(10.90 KB, patch)
2011-03-29 05:18 PDT
,
Ilya Tikhonovsky
no flags
Details
Formatted Diff
Diff
[patch] second version. Assert in inspect() was changed to if.
(10.91 KB, patch)
2011-03-29 06:16 PDT
,
Ilya Tikhonovsky
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Ilya Tikhonovsky
Comment 1
Tuesday, March 29, 2011 1:18:18 PM UTC
Created
attachment 87300
[details]
[patch] initial version
Ilya Tikhonovsky
Comment 2
Tuesday, March 29, 2011 2:16:40 PM UTC
Created
attachment 87304
[details]
[patch] second version. Assert in inspect() was changed to if.
Yury Semikhatsky
Comment 3
Tuesday, March 29, 2011 3:28:03 PM UTC
Comment on
attachment 87304
[details]
[patch] second version. Assert in inspect() was changed to if. View in context:
https://bugs.webkit.org/attachment.cgi?id=87304&action=review
> Source/WebCore/inspector/InspectorDOMAgent.h:163 > + void focusNode();
This one should be private.
Ilya Tikhonovsky
Comment 4
Tuesday, March 29, 2011 5:13:56 PM UTC
Landed
r82263
WebKit Review Bot
Comment 5
Tuesday, March 29, 2011 6:58:02 PM UTC
http://trac.webkit.org/changeset/82263
might have broken GTK Linux 32-bit Release The following tests are not passing: fast/loader/onload-willSendRequest-null-for-frame.html
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug