There are browser related methods and inspector related methods in InspectorAgent. It would be nice to extract browser specific methods for future usage the rest of methods in workers debugger.
Created attachment 87297 [details] [patch] first version
Attachment 87297 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/http..." exit_code: 1 Source/WebCore/inspector/InspectorBrowserAgent.h:70: The parameter name "frame" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/inspector/InspectorBrowserAgent.h:70: The parameter name "world" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/inspector/InspectorBrowserAgent.h:74: The parameter name "frontend" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/inspector/InspectorBrowserAgent.cpp:38: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 4 in 26 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 87298 [details] [patch] rebaselined. style fixed
Created attachment 87314 [details] Inspector.json
Created attachment 87315 [details] Inspector.json
Comment on attachment 87298 [details] [patch] rebaselined. style fixed View in context: https://bugs.webkit.org/attachment.cgi?id=87298&action=review > Source/WebCore/inspector/InspectorAgent.cpp:173 > + m_browserAgent->restore(inspectedURL().string()); PageAgent should simply get url from the page.
landed r82281
Created attachment 87368 [details] the patch I'm going to land
http://trac.webkit.org/changeset/82281 might have broken Qt Linux Release minimal and Qt Windows 32-bit Release
Comment on attachment 87368 [details] the patch I'm going to land View in context: https://bugs.webkit.org/attachment.cgi?id=87368&action=review > Source/WebCore/inspector/InspectorPageAgent.cpp:35 > +#if ENABLE(INSPECTOR) && ENABLE(JAVASCRIPT_DEBUGGER) The page agent should be enabled even if JAVASCRIPT_DEBUGGER is off. > Source/WebCore/inspector/InspectorPageAgent.h:34 > +#if ENABLE(JAVASCRIPT_DEBUGGER) && ENABLE(INSPECTOR) ENABLE(JAVASCRIPT_DEBUGGER) guard should be removed.
(In reply to comment #10) > (From update of attachment 87368 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=87368&action=review > > > Source/WebCore/inspector/InspectorPageAgent.cpp:35 > > +#if ENABLE(INSPECTOR) && ENABLE(JAVASCRIPT_DEBUGGER) > > The page agent should be enabled even if JAVASCRIPT_DEBUGGER is off. > > > Source/WebCore/inspector/InspectorPageAgent.h:34 > > +#if ENABLE(JAVASCRIPT_DEBUGGER) && ENABLE(INSPECTOR) > > ENABLE(JAVASCRIPT_DEBUGGER) guard should be removed. followup patch landed as r82767