Bug 57326 – Remove a bunch of duplicate code by adding some InlineIterator helper methods

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Eric Seidel (no email)]

Remove a bunch of duplicate code by adding some InlineIterator helper methods

[Eric Seidel (no email)]

Created attachment 87295 [details]
Patch

[Ryosuke Niwa]

Comment on attachment 87295 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=87295&action=review

> Source/WebCore/rendering/RenderBlockLineLayout.cpp:1949
>                  if (!currentCharacterIsWS && previousCharacterIsWS) {
> -                    if (autoWrap && o->style()->breakOnlyAfterWhiteSpace()) {
> -                        lBreak.m_obj = o;
> -                        lBreak.m_pos = pos;
> -                        lBreak.m_nextBreakablePosition = nextBreakable;
> -                    }
> +                    if (autoWrap && o->style()->breakOnlyAfterWhiteSpace())
> +                        lBreak.moveTo(o, pos, nextBreakable);

We should just combine these two if statements.

[Eric Seidel (no email)]

Comment on attachment 87295 [details]
Patch

Next patch.

[WebKit Commit Bot]

Comment on attachment 87295 [details]
Patch

Rejecting attachment 87295 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-8', 'apply-..." exit_code: 2

Last 500 characters of output:
 FAILED at 1683.
Hunk #5 FAILED at 1754.
Hunk #6 FAILED at 1850.
Hunk #7 FAILED at 1889.
Hunk #8 FAILED at 1899.
Hunk #9 FAILED at 1908.
Hunk #10 FAILED at 1945.
Hunk #11 FAILED at 2008.
Hunk #12 FAILED at 2038.
Hunk #13 FAILED at 2055.
Hunk #14 FAILED at 2064.
13 out of 14 hunks FAILED -- saving rejects to file Source/WebCore/rendering/RenderBlockLineLayout.cpp.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Ryosuke Niwa', u'--for..." exit_code: 1

Full output: http://queues.webkit.org/results/8282306

[WebKit Commit Bot]

Comment on attachment 87295 [details]
Patch

Rejecting attachment 87295 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-7', 'apply-..." exit_code: 2

Last 500 characters of output:
 FAILED at 1683.
Hunk #5 FAILED at 1754.
Hunk #6 FAILED at 1850.
Hunk #7 FAILED at 1889.
Hunk #8 FAILED at 1899.
Hunk #9 FAILED at 1908.
Hunk #10 FAILED at 1945.
Hunk #11 FAILED at 2008.
Hunk #12 FAILED at 2038.
Hunk #13 FAILED at 2055.
Hunk #14 FAILED at 2064.
13 out of 14 hunks FAILED -- saving rejects to file Source/WebCore/rendering/RenderBlockLineLayout.cpp.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Ryosuke Niwa', u'--for..." exit_code: 1

Full output: http://queues.webkit.org/results/8283285

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 87295 [details]:

java/lc3/JSObject/ToObject-001.html bug 53091 (author: [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 87295 [details]
Patch

Clearing flags on attachment: 87295

Committed r82277: <http://trac.webkit.org/changeset/82277>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[WebKit Review Bot]

http://trac.webkit.org/changeset/82277 might have broken Leopard Intel Debug (Tests)