Bug 57314 - [Qt] Add -print-loaded-urls option to Qt's MiniBrowser and to QtTestBrowser
Summary: [Qt] Add -print-loaded-urls option to Qt's MiniBrowser and to QtTestBrowser
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Zoltan Horvath
URL:
Keywords: Qt
Depends on:
Blocks:
 
Reported: 2011-03-29 01:44 PDT by Zoltan Horvath
Modified: 2011-03-29 06:37 PDT (History)
0 users

See Also:

Attachments
proposed patch (6.56 KB, patch)
2011-03-29 01:46 PDT, Zoltan Horvath 		kling: review-
Details | Formatted Diff | Diff
proposed patch (6.58 KB, patch)
2011-03-29 06:16 PDT, Zoltan Horvath 		kling: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zoltan Horvath 2011-03-29 01:44:48 PDT 
Provide possibility to print loaded urls to the standard output.
Comment 1 Zoltan Horvath 2011-03-29 01:46:28 PDT 
Created attachment 87282 [details]
proposed patch
Comment 2 Andreas Kling 2011-03-29 06:15:45 PDT 
Comment on attachment 87282 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=87282&action=review

r-, comments on irc

> Tools/MiniBrowser/qt/BrowserWindow.cpp:65
> +    if (m_windowOptions.printLoadedUrls)
> +        connect(page(), SIGNAL(urlChanged(const QUrl&)), this, SLOT(printURL()));

We typically normalize signal/slot names so Qt doesn't have to do it for us.
"urlChanged(const QUrl&)" -> "urlChanged(QUrl)"

printURL() should take the const QUrl& argument and print that instead of fetching it from the view.
Comment 3 Zoltan Horvath 2011-03-29 06:16:23 PDT 
Created attachment 87303 [details]
proposed patch
Comment 4 Zoltan Horvath 2011-03-29 06:16:49 PDT 
Comment on attachment 87303 [details]
proposed patch

Thanks for the comments.
Comment 5 Andreas Kling 2011-03-29 06:20:18 PDT 
Comment on attachment 87303 [details]
proposed patch

Shazam!
Comment 6 Zoltan Horvath 2011-03-29 06:37:40 PDT 
Thank you!

Landed in r82244.
http://trac.webkit.org/changeset/82244