RESOLVED FIXED Bug 57299
Web Inspector: document Timeline domain, make timeline event types of type string. 
https://bugs.webkit.org/show_bug.cgi?id=57299
Summary Web Inspector: document Timeline domain, make timeline event types of type st...
Pavel Feldman
Reported 2011-03-28 22:28:40 PDT
Patch to follow.
Attachments
Patch (31.50 KB, patch)
2011-03-28 22:39 PDT, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
[PATCH] Patch that compiles. (30.75 KB, patch)
2011-03-28 23:08 PDT, Pavel Feldman 		yurys: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2011-03-28 22:39:08 PDT
Created attachment 87262 [details] Patch
WebKit Review Bot
Comment 2 2011-03-28 22:42:53 PDT
Attachment 87262 [details] did not build on chromium: Build output: http://queues.webkit.org/results/8281066
Early Warning System Bot
Comment 3 2011-03-28 22:43:51 PDT
Attachment 87262 [details] did not build on qt: Build output: http://queues.webkit.org/results/8280068
Build Bot
Comment 4 2011-03-28 23:02:00 PDT
Attachment 87262 [details] did not build on win: Build output: http://queues.webkit.org/results/8285071
Pavel Feldman
Comment 5 2011-03-28 23:08:16 PDT
Created attachment 87264 [details] [PATCH] Patch that compiles.
Yury Semikhatsky
Comment 6 2011-03-29 04:21:44 PDT
Comment on attachment 87264 [details] [PATCH] Patch that compiles. View in context: https://bugs.webkit.org/attachment.cgi?id=87264&action=review > Source/WebCore/inspector/InspectorTimelineAgent.cpp:54 > +static const char EventDispatch[] = "EventDispatch"; Could we sort them alphabetically. > Source/WebCore/inspector/front-end/TimelineAgent.js:37 > + EventDispatch: "EventDispatch", We should enumerated these constants in the .json scheme. This deserves its own change, please file a bug and put a FIXME here.
Pavel Feldman
Comment 7 2011-03-29 06:05:42 PDT
Committed r82239: <http://trac.webkit.org/changeset/82239>
WebKit Review Bot
Comment 8 2011-03-29 06:21:32 PDT
http://trac.webkit.org/changeset/82239 might have broken Qt Linux Release minimal
Note You need to log in before you can comment on or make changes to this bug.