Bug 57299 - Web Inspector: document Timeline domain, make timeline event types of type string.
Summary: Web Inspector: document Timeline domain, make timeline event types of type st...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-28 22:28 PDT by Pavel Feldman
Modified: 2011-03-29 06:21 PDT (History)
16 users (show)

See Also:

Attachments
Patch (31.50 KB, patch)
2011-03-28 22:39 PDT, Pavel Feldman 		no flags Details | Formatted Diff | Diff
[PATCH] Patch that compiles. (30.75 KB, patch)
2011-03-28 23:08 PDT, Pavel Feldman 		yurys: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2011-03-28 22:28:40 PDT 
Patch to follow.
Comment 1 Pavel Feldman 2011-03-28 22:39:08 PDT 
Created attachment 87262 [details]
Patch
Comment 2 WebKit Review Bot 2011-03-28 22:42:53 PDT 
Attachment 87262 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/8281066
Comment 3 Early Warning System Bot 2011-03-28 22:43:51 PDT 
Attachment 87262 [details] did not build on qt:
Build output: http://queues.webkit.org/results/8280068
Comment 4 Build Bot 2011-03-28 23:02:00 PDT 
Attachment 87262 [details] did not build on win:
Build output: http://queues.webkit.org/results/8285071
Comment 5 Pavel Feldman 2011-03-28 23:08:16 PDT 
Created attachment 87264 [details]
[PATCH] Patch that compiles.
Comment 6 Yury Semikhatsky 2011-03-29 04:21:44 PDT 
Comment on attachment 87264 [details]
[PATCH] Patch that compiles.

View in context: https://bugs.webkit.org/attachment.cgi?id=87264&action=review

> Source/WebCore/inspector/InspectorTimelineAgent.cpp:54
> +static const char EventDispatch[] = "EventDispatch";

Could we sort them alphabetically.

> Source/WebCore/inspector/front-end/TimelineAgent.js:37
> +    EventDispatch: "EventDispatch",

We should enumerated these constants in the .json scheme. This deserves its own change, please file a bug and put a FIXME here.
Comment 7 Pavel Feldman 2011-03-29 06:05:42 PDT 
Committed r82239: <http://trac.webkit.org/changeset/82239>
Comment 8 WebKit Review Bot 2011-03-29 06:21:32 PDT 
http://trac.webkit.org/changeset/82239 might have broken Qt Linux Release minimal