We were duplicating code to create a CFDataRef containing a PCCERT_CONTEXT in multiple places, so move this into WebCore.
Created attachment 87256 [details] Patch
Comment on attachment 87256 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=87256&action=review r=me > Source/WebCore/WebCore.vcproj/WebCore.vcproj:26584 > + Name="win" > + > > + <File > + RelativePath="..\platform\cf\win\CertificateCF.cpp" > + > Windows-only files are usually named *Win.cpp > Source/WebCore/platform/cf/win/CertificateCF.cpp:26 > + * Redistribution and use in source and binary forms, with or without > + * modification, are permitted provided that the following conditions > + * are met: > + * > + * 1. Redistributions of source code must retain the above copyright > + * notice, this list of conditions and the following disclaimer. > + * 2. Redistributions in binary form must reproduce the above copyright > + * notice, this list of conditions and the following disclaimer in the > + * documentation and/or other materials provided with the distribution. > + * 3. Neither the name of Apple Computer, Inc. ("Apple") nor the names of > + * its contributors may be used to endorse or promote products derived > + * from this software without specific prior written permission. > + * > + * THIS SOFTWARE IS PROVIDED BY APPLE AND ITS CONTRIBUTORS "AS IS" AND ANY > + * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED > + * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE > + * DISCLAIMED. IN NO EVENT SHALL APPLE OR ITS CONTRIBUTORS BE LIABLE FOR ANY > + * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES > + * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; > + * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND > + * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT > + * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF > + * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. There is a newer 2-clause version of this license that you should use. See DownloadCFNet.cpp
Comment on attachment 87256 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=87256&action=review >> Source/WebCore/WebCore.vcproj/WebCore.vcproj:26584 >> + > > > Windows-only files are usually named *Win.cpp In this case, I think CertificateCFWin.cpp would be appropriate.
Committed r82247: <http://trac.webkit.org/changeset/82247>